Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow functionality to skip a bench #23

Open
devinus opened this issue Aug 30, 2014 · 3 comments
Open

Allow functionality to skip a bench #23

devinus opened this issue Aug 30, 2014 · 3 comments

Comments

@devinus
Copy link

devinus commented Aug 30, 2014

  bench "String Escaping (JSEX)", [string: gen_string] do
    # JSX doesn't support escaping unicode, it's unsupported
    :timer.sleep(1000)
  end

Maybe color it red in the results?

@alco
Copy link
Owner

alco commented Aug 30, 2014

I don't understand. If there is nothing to benchmark, why write the test in the first place?

@devinus
Copy link
Author

devinus commented Aug 30, 2014

Well, I'm writing a suite of tests that test different functionality for different libraries, and sometimes a library simply wont have that feature.I'd like to not just exclude the test since it's slightly confusing unless you know it's unsupported.

@alco
Copy link
Owner

alco commented Aug 31, 2014

So you have the same benchmark suite for different libraries? If that is the case, that might not be supported for quite some time if at all. I'd like to keep benchfella narrow in scope for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants