From b0cd00a3e24fa84ba863b0f81c2fe37ba56dc057 Mon Sep 17 00:00:00 2001 From: Meer Sawood Date: Mon, 23 Oct 2023 14:07:30 +0530 Subject: [PATCH] chore: enabling push metrics on openshift ci (#830) * enabling push metrics on openshift ci * small fix * added some more fixes * Adding me as an approver --- .github/workflows/loadtest.yaml | 1 + OWNERS | 1 + tests/load-tests/run-max-concurrency.sh | 2 +- tests/load-tests/run-stage.sh | 1 + tests/load-tests/run.sh | 2 +- 5 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/loadtest.yaml b/.github/workflows/loadtest.yaml index 63aad41cb..562d80fca 100644 --- a/.github/workflows/loadtest.yaml +++ b/.github/workflows/loadtest.yaml @@ -40,6 +40,7 @@ jobs: USERS_PER_THREAD: ${{ github.event.inputs.users }} THREADS: ${{ github.event.inputs.threads }} PUSHGATEWAY_URL: ${{ secrets.PUSHGATEWAY_URL }} + DISABLE_METRICS: ${{ secrets.DISABLE_METRICS }} run: ./run-stage.sh - name: Collect results diff --git a/OWNERS b/OWNERS index d7f91be5a..178e4f4c9 100644 --- a/OWNERS +++ b/OWNERS @@ -22,3 +22,4 @@ approvers: - jkopriva - Dannyb48 - psturc +- sawood14012 diff --git a/tests/load-tests/run-max-concurrency.sh b/tests/load-tests/run-max-concurrency.sh index 7d4cf46ab..f7de0048d 100755 --- a/tests/load-tests/run-max-concurrency.sh +++ b/tests/load-tests/run-max-concurrency.sh @@ -23,7 +23,7 @@ load_test() { -l \ -o "$output_dir" \ -t "$threads" \ - --disable-metrics \ + --disable-metrics="${DISABLE_METRICS:-false}" \ --pushgateway-url "${PUSHGATEWAY_URL:-rhtapqe.com}" \ --enable-progress-bars="${ENABLE_PROGRESS_BARS:-false}" \ --pipeline-skip-initial-checks="${PIPELINE_SKIP_INITIAL_CHECKS:-true}" diff --git a/tests/load-tests/run-stage.sh b/tests/load-tests/run-stage.sh index 4d5a6b0e7..04775de59 100755 --- a/tests/load-tests/run-stage.sh +++ b/tests/load-tests/run-stage.sh @@ -12,6 +12,7 @@ go run loadtest.go \ -l \ -o "${OUTPUT_DIR:-.}" \ -t "${THREADS:-2}" \ + --disable-metrics="${DISABLE_METRICS:-false}" \ --pushgateway-url "${PUSHGATEWAY_URL:-rhtapqe.com}" \ --enable-progress-bars="${ENABLE_PROGRESS_BARS:-false}" \ --pipeline-skip-initial-checks="${PIPELINE_SKIP_INITIAL_CHECKS:-true}" diff --git a/tests/load-tests/run.sh b/tests/load-tests/run.sh index fcc4c0300..cb77b8022 100755 --- a/tests/load-tests/run.sh +++ b/tests/load-tests/run.sh @@ -66,7 +66,7 @@ else -o "$output_dir" \ -t "${THREADS:-1}" \ $RANDOM_PREFIX_FLAG \ - --disable-metrics \ + --disable-metrics="${DISABLE_METRICS:-false}" \ --pushgateway-url "${PUSHGATEWAY_URL:-rhtapqe.com}" \ --enable-progress-bars="${ENABLE_PROGRESS_BARS:-false}" \ --pipeline-skip-initial-checks="${PIPELINE_SKIP_INITIAL_CHECKS:-true}"