Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaUtils does not use configuration entries #500

Closed
Tochemey opened this issue Jan 23, 2021 · 2 comments
Closed

SchemaUtils does not use configuration entries #500

Tochemey opened this issue Jan 23, 2021 · 2 comments

Comments

@Tochemey
Copy link
Contributor

Tochemey commented Jan 23, 2021

I have observed that the following configuration entries are ignored when using SchemaUtils.createIfNotExists()

The same applies to legacy schema. This can be damaging to applications that do not use the default public postgres schema. Yeah someone can say that tool is merely for testing but I don't think dev should be copying db schemas all over the place for production. It is like telling someone after buying a car to also buy the engine before it can be driven. 😀

@octonato
Copy link
Member

@Tochemey, the tool is for testing. By default, it loads schema we show in the docs.

It doesn't have the ambition to cover all the cases. However, there is an escape hatch if you need load a tweaked schema, for that you should use SchemaUtils.applyScript. You can then pass whatever script you want.

I understand that it would be more convenient to have it reading the user defined configuration, but since there is already an escape hatch for that edge case, I'm not sure if it's worth the extra effort.

@Tochemey
Copy link
Contributor Author

@octonato Great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants