Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard distortion type: Clean-up observer patterns when a Proxy is revoked (ex: addEventListener) #217

Open
ajvincent opened this issue Sep 13, 2019 · 0 comments

Comments

@ajvincent
Copy link
Owner

<html>
<head>
  <title></title>
  <meta charset="UTF-8">
</head>
<body>
  <button id="foo">Hello</button>
  <button id="revoke" onclick="revoke();">Revoke</button>
</body>
</html>
function fooHandler() {
  console.log("fooHandler");
}

const {proxy: fooProxy, revoke: fooRevoke} = Proxy.revocable(fooHandler, Reflect);
var revoke, foo;
{
   let revoked = false;
   revoke = () => {
     if (revoked)
       return;
     revoked = true;
     fooRevoke();
     foo.removeEventListener("click", fooProxy, true);
   }
}

window.onload = function() {
  foo = document.getElementById("foo");
  foo.addEventListener("click", fooProxy, true);
};

If we called fooRevoke() directly without revoke(), then anytime we clicked the foo button, we'd trigger an exception for the revoked proxy.

@ajvincent ajvincent modified the milestone: 0.10 Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant