You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to #PR3904reviews the cli/pkg/providers/provider.go package's Provider interface needs to be improved. And the changes should be reflected on cli/pkg/providers/provider_name_here.
Recommendations are below:
All providers' go files has this function below. It is always better to return a struct and not a pointer specially when the struct only contains pointers
console.Exit will kill the process, so in case of error this function will never return. those error is always nil. in this case there is golang convention for this.
The function should not return a value, and it is better if you call it MustProvision
The text was updated successfully, but these errors were encountered:
According to #PR3904reviews the
cli/pkg/providers/provider.go
package'sProvider interface
needs to be improved. And the changes should be reflected oncli/pkg/providers/provider_name_here
.Recommendations are below:
All providers' go files has this function below. It is always better to return a struct and not a pointer specially when the struct only contains pointers
For Provision() function:
The function should not return a value, and it is better if you call it MustProvision
The text was updated successfully, but these errors were encountered: