Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Switch away from json #1431

Open
HaoZeke opened this issue Sep 9, 2024 · 1 comment · May be fixed by #1432
Open

ENH: Switch away from json #1431

HaoZeke opened this issue Sep 9, 2024 · 1 comment · May be fixed by #1432

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Sep 9, 2024

Related to #1430 and also recent discussions / changes adding support for jsonc by @lucascolley. I've been thinking this would all be a lot simpler to just switch to using TOML instead of json. Comments would have first class support, and it is pretty much standardized into Python now anyway. Plus it works better with the pydantic stuff I had in mind.

Will have a PR for this shortly, but thoughts welcome.
@HaoZeke
Copy link
Member Author

HaoZeke commented Sep 9, 2024

Also worth noting we already have a hard dependency on tomli for environment.py anyway, so this is only going to help.

@HaoZeke HaoZeke linked a pull request Sep 9, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Switch to TOML and use Pydantic for validation HaoZeke/asv
1 participant
@HaoZeke