-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read sync input as IEnumerable<ImmutableArray<string>> #21
Comments
Base implementation probably needs to spin up a thread so that the visitor methods can block while our consumer processes the results. That said, I think every subclass can do a lot better by reimplementing their input reading logic. |
Hmm, a more flexible API would be to have just one virtual method that returns something that can be configured like how the input classes work. I kinda want to limit the default max field length and let callers control it. |
Then again, I've come down elsewhere on the side of, "if you have some encoding other than UTF-8, then most helpers won't work for you". So only one parameter is needed. |
Ugh. The ideal would be But of course, Custom And Ugh. |
Ugh. Of course that's not true: we also have Ugh. |
Someone might pull the next element from the outer sequence before fully consuming the previous element from the inner sequence (which is really easy to do with |
On
CsvSyncInputBase
:The text was updated successfully, but these errors were encountered: