Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression: is not in NNF #612

Open
MFaisalZaki opened this issue Jun 23, 2024 · 4 comments
Open

Expression: is not in NNF #612

MFaisalZaki opened this issue Jun 23, 2024 · 4 comments

Comments

@MFaisalZaki
Copy link

Describe the bug
I'm using the NEGATIVE_CONDITIONS_REMOVING for the schedule domain, and it throws this exception when parsing this
Screenshot 2024-06-23 at 11 55 18 AM

Here is the code to reproduce the bug:


from unified_planning.io import PDDLReader
from unified_planning.shortcuts import Compiler, CompilationKind

domain  = 'domain.pddl'
problem = 'probschedule-2-0.pddl'

task = PDDLReader().parse_problem(domain, problem)
with Compiler(problem_kind = task.kind, 
    compilation_kind = CompilationKind.NEGATIVE_CONDITIONS_REMOVING) as neg_condition_remover:
    ncr_result = neg_condition_remover.compile(task, CompilationKind.NEGATIVE_CONDITIONS_REMOVING)

planning-task.zip

@alvalentini
Copy link
Member

Thanks @MFaisalZaki for the bug report! I will have a look asap!

@alvalentini
Copy link
Member

The problem here is that the negative conditions remover is not able to remove the negative condition that appears in the exception. At the moment the compiler is only able to remove negation of boolean fluents.

To fix the issue we should reduce the supported problem kind (easy solution) or extend the compiler to handle these kind of negative conditions (more complex).

@MFaisalZaki
Copy link
Author

This makes sense. I would suggest keeping this issue open and when the fix is available we can close this issue. What do you think?

@alvalentini
Copy link
Member

I agree, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants