Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't build with PyTorch 1.11 #550

Open
igormp opened this issue Apr 21, 2022 · 5 comments
Open

Won't build with PyTorch 1.11 #550

igormp opened this issue Apr 21, 2022 · 5 comments

Comments

@igormp
Copy link

igormp commented Apr 21, 2022

The current code won't build with PyTorch 1.11, since it seems that they removed the TH/THC include files, as per this comment: open-mmlab/mmdetection3d#1332 (comment)

The end result is this:

AdelaiDet/adet/layers/csrc/ml_nms/ml_nms.cu:4:10: fatal error: THC/THC.h: No such file or directory
    4 | #include <THC/THC.h>
      |          ^~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.
@igormp
Copy link
Author

igormp commented Apr 21, 2022

Seems like #518 fixes this issue.

@vanga
Copy link

vanga commented Jun 17, 2022

I have this working on Colab with pytorch 1.11. But, I get this error on Linux, A100 with pytorch being the same version.

torch                   1.11.0+cu113
torchaudio              0.11.0+cu113
torchvision             0.12.0+cu113
/AdelaiDet/adet/layers/csrc/ml_nms/ml_nms.cu:4:10: fatal error: THC/THC.h: No such file or directory
 #include <THC/THC.h>
          ^~~~~~~~~~~
compilation terminated.
error: command '/usr/local/cuda-11.3/bin/nvcc' failed with exit code 1

is it related to cuda package then?

@vanga
Copy link

vanga commented Jun 17, 2022

I got it working with the change from the PR #518 and also removing line 4 as mentioned in the PR comments

#include <THC/THC.h>

@visionKinger
Copy link

I got it working with the change from the PR #518 and also removing line 4 as mentioned in the PR comments

#include <THC/THC.h>

after removing the line 4,more error happened

@2605759123
Copy link

I got it working with the change from the PR #518 and also removing line 4 as mentioned in the PR comments

#include <THC/THC.h>

It works. Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants