-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Pyproject migration #203
Draft
danielhollas
wants to merge
10
commits into
aiidalab:main
Choose a base branch
from
danielhollas:pyproject-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dbbb407
Migrate mypy and pytest config
danielhollas e6c045c
Remove check-manifest pre-commit hook
danielhollas df5d3d9
Remove setup.py
danielhollas a7599c7
Migrate fully to pyproject and flit
danielhollas a8a6400
remove check-toml hook, ruff gets us covered
danielhollas 794f174
Move .coveragerc to pyproject
danielhollas d60390b
Add cache folders to gitignore
danielhollas 8215a53
Revert "Add cache folders to gitignore"
danielhollas 8e9023e
Flit include/exclude in pyproject.toml
danielhollas 26f0cee
Remove MANIFEST.in
danielhollas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,74 @@ | ||
# TODO: Move entire setup.cfg to pyproject.toml | ||
[build-system] | ||
requires = ["flit_core >=3.2,<4"] | ||
build-backend = "flit_core.buildapi" | ||
|
||
[project] | ||
name = "aiidalab_launch" | ||
authors = [{name = "Carl Simon Adorf and the AiiDAlab team", email = "[email protected]"}] | ||
readme = "README.md" | ||
license = {file = "LICENSE"} | ||
description = "Tool to launch AiiDAlab on a local workstation." | ||
dynamic = ["version"] | ||
requires-python = '>=3.8' | ||
|
||
classifiers = [ | ||
'Development Status :: 5 - Production/Stable', | ||
'Framework :: AiiDA', | ||
'License :: OSI Approved :: MIT License', | ||
'Operating System :: POSIX :: Linux', | ||
'Operating System :: MacOS :: MacOS X', | ||
'Programming Language :: Python :: 3', | ||
'Programming Language :: Python :: 3 :: Only', | ||
'Programming Language :: Python :: Implementation :: CPython', | ||
'Topic :: Scientific/Engineering', | ||
] | ||
|
||
dependencies = [ | ||
'click==8.1', | ||
'click-spinner==0.1.10', | ||
'docker==7.0.0', | ||
'packaging==21.3', | ||
'requests==2.26.0', | ||
'requests-cache==0.9.1', | ||
'tabulate==0.9.0', | ||
'toml==0.10.2', | ||
] | ||
|
||
[project.scripts] | ||
aiidalab-launch = "aiidalab_launch.__main__:cli" | ||
|
||
[project.urls] | ||
Home = "https://github.com/aiidalab/aiidalab-launch" | ||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
'bumpver==2023.1129', | ||
'dunamai==1.19.0', | ||
'pre-commit>=3.5.0', | ||
] | ||
|
||
tests = [ | ||
'pytest~=7.4.3', | ||
'pytest-asyncio~=0.21.1', | ||
'pytest-cov~=4.1.0', | ||
'responses~=0.23.1', | ||
] | ||
|
||
[tool] | ||
|
||
[tool.mypy] | ||
warn_unused_configs = true | ||
disallow_untyped_calls = true | ||
|
||
[[tool.mypy.overrides]] | ||
module = "docker.*" | ||
ignore_missing_imports = true | ||
|
||
[tool.pytest.ini_options] | ||
addopts = ["--cov=aiidalab_launch", "--cov-fail-under=80"] | ||
asyncio_mode = "auto" | ||
markers = ["slow: marks tests as slow"] | ||
filterwarnings = ["ignore::DeprecationWarning:docker.*:"] | ||
|
||
[tool.ruff] | ||
line-length = 88 | ||
|
@@ -23,3 +93,27 @@ select = [ | |
|
||
[tool.ruff.lint.per-file-ignores] | ||
"tests/*" = ["ARG001"] | ||
|
||
[tool.bumpver] | ||
current_version = "v2023.1019" | ||
version_pattern = "vYYYY.BUILD[PYTAGNUM]" | ||
commit_message = "Bump version {old_version} -> {new_version}" | ||
commit = true | ||
tag = true | ||
push = true | ||
|
||
[tool.bumpver.file_patterns] | ||
"aiidalab_launch/version.py" = [ | ||
'__version__ = "{version}"', | ||
] | ||
|
||
[tool.coverage.run] | ||
omit = [ | ||
'*/venv/*', | ||
'*/tests/*', | ||
'*/docs/*', | ||
'*/dist/*', | ||
] | ||
|
||
[tool.coverage.html] | ||
directory = './htmlcov' |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed, since
ruff
already parsespyproject.toml
and prints nice errors if there is a problem.