Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can delete more than one profiles at one time #173

Open
unkcpz opened this issue Mar 22, 2023 · 2 comments · May be fixed by #190
Open

Can delete more than one profiles at one time #173

unkcpz opened this issue Mar 22, 2023 · 2 comments · May be fixed by #190
Labels
enhancement New feature or request
Milestone

Comments

@unkcpz
Copy link
Member

unkcpz commented Mar 22, 2023

aiidalab-launch profiles delete now only accept one profile a time to delete. -a for delete all maybe too much but at least I can put more profiles to delete at once.

@unkcpz unkcpz added the enhancement New feature or request label Mar 22, 2023
@unkcpz
Copy link
Member Author

unkcpz commented Mar 26, 2023

Here is how I did in order to remove the volumes created with the container, I first stop the container and remove the container, which also should be managed by aiidalab-launch profiles remove, and then runs:

docker volume rm $(docker volume ls -qf dangling=true)

EDIT: this is related to #172

@unkcpz unkcpz added this to the v2023.1019 milestone May 29, 2023
@unkcpz unkcpz modified the milestones: v2023.1019, v2023.1020 Jul 10, 2023
@danielhollas
Copy link
Contributor

I am quite conflicted about this feature. It seems like an unnecessary complication and potentially dangerous, given that the workaround is to use a simple BASH loop or xargs. Also since we renamed the subcommand from profiles to profile it also seems confusing in that sense.

For example this oneliner would delete all profiles including the volumes (after #172 is merged)

aiidalab-launch profile list | awk '{print $1}' | xargs -n 1 aiidalab-launch profile delete --purge --yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants