Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELO conflict in match participations #638

Open
lladdy opened this issue Oct 19, 2023 · 4 comments
Open

ELO conflict in match participations #638

lladdy opened this issue Oct 19, 2023 · 4 comments
Assignees

Comments

@lladdy
Copy link
Contributor

lladdy commented Oct 19, 2023

As detailed here: https://discord.com/channels/430111136822722590/853250973325328384/1160857761169547404

@lladdy lladdy converted this from a draft issue Oct 19, 2023
@lladdy lladdy self-assigned this Oct 19, 2023
@lladdy lladdy moved this from 📋 Backlog to 🏗 In progress in General Tasks Oct 19, 2023
@lladdy
Copy link
Contributor Author

lladdy commented Oct 24, 2023

Turns out the ELO conflict we're seeing isn't unintentional.

starting_elo = models.SmallIntegerField(null=True)
"""The bot's ELO at the time the match started
Note that this isn't necessarily the same as resultant_elo - elo_change."""

Note that this isn't necessarily the same as resultant_elo - elo_change."""

This is confusing though. If I can't think of any reason for keeping it this way, I will change this behavior to instead have starting_elo be the ELO value before the result adjustment is applied.

@lladdy
Copy link
Contributor Author

lladdy commented Oct 24, 2023

This begs the question of why yatahunt appeared to initially observe the ELO value for their bot reverting randomly when re-loading the rankings page, as detailed here: https://discord.com/channels/430111136822722590/853250973325328384/1159576233416343667

Potentially this is caused by some less critical issue, such as caching.

Possible suggestion:
As per my reply above, change starting_elo to be the ELO value before the result adjustment is applied. Then this can be used to more easily either confirm or rule out an ELO allocation issue.

@lladdy
Copy link
Contributor Author

lladdy commented Nov 9, 2023

Update:
There is actually some sort of issue causing ELOs to drift.
The total ELO stays constant though.
This issue has risen in occurrence since the rise in AC api usage (potentially due to micro ladder + more ACs).

@lladdy
Copy link
Contributor Author

lladdy commented Nov 22, 2023

No longer urgent to fix before next seasons, as AWS is running as a single container and thus this won't be an issue.

@lladdy lladdy moved this from 🏗 In progress to 📋 Backlog in General Tasks Dec 14, 2023
@lladdy lladdy moved this from 📋 Backlog to 🏗 Todo in General Tasks Mar 10, 2024
@lladdy lladdy moved this from 🏗 Todo to 📋 Backlog in General Tasks Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant