Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reading schemas not defined in schema.min.json (dat file with no fields) #44

Open
zaafar opened this issue Jan 10, 2023 · 2 comments
Labels
Bug Dat File Problem handling .dat files in Bundles2/Data Won't Fix This will not be worked on

Comments

@zaafar
Copy link
Contributor

zaafar commented Jan 10, 2023

There are some Enums in the schema.min.json with no values e.g.

enum AchievementSets @indexing(first: 0) { _ }

These are different from enums that have values e.g.

enum ActiveSkillTargetTypes @indexing(first: 1) {
  TARGETABLE_GROUND
  ENEMY
  WALKABLE_GROUND
  ANYWHERE_SELF_TARGET
  ITEM
  CORPSE
  _
  NO_LINE_OF_SIGHT
  BEHIND_MONSTER
  SELF_ORIGIN
  ROTATE_TO_TARGET
}

Libggpk2 crashes on these undefined enums as shown below.

image

It would be good if Libggpk2 don't crash on them and just consider them as integer starting from what's given in bracket i.e. (first: 1).

@aianlinb aianlinb added Bug Dat File Problem handling .dat files in Bundles2/Data labels Jan 14, 2023
@aianlinb aianlinb added the Won't Fix This will not be worked on label Feb 11, 2023
@zaafar
Copy link
Contributor Author

zaafar commented Feb 11, 2023

@aianlinb not even in libggpk3?

@aianlinb
Copy link
Owner

@zaafar Well... I'll solve it in the future when I have time to continue developing LibGGPK3, LibDat3

@aianlinb aianlinb changed the title Error when reading schema.min.json enums Error reading schemas not defined in schema.min.json (dat file with no fields) Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dat File Problem handling .dat files in Bundles2/Data Won't Fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants