Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to support a list of condition types #48

Open
hectorj2f opened this issue Nov 30, 2021 · 3 comments
Open

Add a flag to support a list of condition types #48

hectorj2f opened this issue Nov 30, 2021 · 3 comments

Comments

@hectorj2f
Copy link

The current implementation only supports a condition with type Ready. However it could be great to support additional condition types that can be used on custom resource types.

As an example,

kubectl tree customresource --ready-cond-types=Ready,Processed,Scheduled....`
@ahmetb
Copy link
Owner

ahmetb commented Nov 30, 2021

Are you saying instead of READY=true/false, we should accept a list of conditions and show them all?
I am open to patches, although the Ready condition is pretty standard practice per kstatus.
Perhaps the more advanced lineage plugin can also be a good place to add this.

@hectorj2f
Copy link
Author

@ahmetb I ack the usage of Ready=True on conditions however there might be situations where other conditions should also be considered to be reported in the tree (maybe because Ready means something different for that customer resource). Therefore, I would suggest to have a flag that defines the list of condition types that can be accepted to appear in the tree, e.g. Scheduled=True, Ready=True, Processed=True so that would be --ready-cond-types=Ready,Processed,Scheduled

@ahmetb
Copy link
Owner

ahmetb commented Nov 30, 2021

Yeah I think it's doable. It'll make the output hard to fit on the screen but feel free to prototype it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants