-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Progress Indicator while sharing files between devices #9
Comments
Please NO. It will be highly annoying to unzip files which defeats the whole purpose of seamlessness. Update: Had a look and updating everything to UNUserNotification is needed. |
I agree with you because it's more of a hassle and that's why I mentioned that it's unlikely and an inefficient way of doing it. I did get the download complete notification working, so that's a step forward. |
@sannidhyaroy Can you share some more info on how I can replace the NSNotification to UNUserNotification myself? |
@electr1fy0 You first make an if #available(macOS 11.0, *) statement and then implement the UNNotification System and move the NSNotification code to the else statement, as UNNotification isn't available in earlier macOS versions. If you want to learn about UNNotification, there's a YouTube video (https://youtu.be/mIztoF9CzP8) which will explain the basics of implementing it. Hope it helps you out! You could also check out the code from the beta branch of Soduto in my Git Repository |
@sannidhyaroy I'm having some trouble compiling your beta repo. |
@electr1fy0 I released a build on the recent working version prior to adding the share extension here (https://github.com/sannidhyaroy/Soduto/releases/tag/v1.0.4-beta). The notification system and existing features work. I'll release a build with the share extension in the future if I can get it working. As of now, the app crashes when I try to send a file though it. |
Oh great, I managed to build it from your repo too and I do get the 'File Sending' notification. |
@electr1fy0 I did fix the "Launch on Login" issue but I'm yet to push those commits to GitHub. Apple broke the Login Items code with macOS Ventura and it now uses the SMAppService to manage Login Items. You can read more about it here EDIT: I think I did push it to GitHub. Try to build and create an archive from Xcode using the source code of the most recent commit from my beta branch. Do let me know if you get it working. You can check the code in the Configuration.swift file inside A lot of features broke because Soduto wasn't in active development and hence the code was deprecated. |
Yes, you did push it in your fork but it's still broken at least for me. IIRC it said SMAppService is missing or something. |
@sannidhyaroy Even the Soduto Share feature that you implemented in the nightly shows this: Could you release a build so that I can be sure something is wrong on my end? |
@electr1fy0 The I'll release a build, so check back within an hour or so... Since, I don't have a paid Apple Developer account, when you'll be installing Soduto, Gatekeeper will block the app from opening. You'll have to go to |
It may be possible that my code didn't fix it. Since, I can't reproduce the issue on my system, it'll be hard for me to actually fix it. I have released the beta build, so do let me know if you still face the issue or not. The nighly build (which has the share extension) will take longer for me to release. And about the issue, you're facing with the share extension, I released a commit yesterday which probably should have fixed the issue, so you can try to build the nightly branch again or wait for me to release the nightly build. Also, note that nightly is buggy (which is why it's nightly), so as of now, it works only for single files. If you try to select multiple files, it will send one file over and over again. |
@sannidhyaroy That worked! |
Glad to know, it's working! |
Unfortunately, I still couldn't get |
If it's working on the build that I released but not on yours, then there something wrong with the build options or frameworks in Xcode. The issue with Soduto Share was because we had to make sure the same App Group key was pasted in the code which I realized later and updated the readme accordingly, but I can't think of any possible reason why |
@electr1fy0 Hey, I tried to add actions, replies, requests and dismiss options in Soduto Notifications. I don't know if it's stable enough. I released a nightly build, so feel free to check it out. |
Hi @sannidhyaroy, thanks for the great job and I also got the |
If you get the And if you have a couple of minutes, it'd be great if you could open an issue regarding this in my repository, so that I can keep track of what is to be implemented and fixed in the next nightly version. |
For me, the DMG you released worked fine IIRC but not when I built myself. |
Omg, that sounds confusing cuz @emdoe said that none worked for him. @emdoe Can you do a fresh reinstall of Soduto Nightly? Make sure to remove the remaining files too using AppCleaner and remove all entries starting with |
It starts to seem really odd to me. After a fresh installation, the option on the login item has disappeared. |
You need to clear the .plist file of login items in your mac. This has nothing to do with Soduto and is a common macOS issue. I faced this same one time as well. Can you make a backup (of only this file)and then delete |
Thanks for the information! However, there is no changes and the option is still missing from the |
No idea, what's goin' on tbh 😂 |
By manually adding Soduto to the login item list via System Settings, the menu item toggle returns to normal. And you can control the "launch on login" settings via the menu item again after that. There's a way to manually trigger this issue: turn on the "launch on login" via menu item; then open System Settings, select Soduto in the login item list, then click on the "-" button to remove it. After that the "launch on login" menu item will show the "-" sign, and you cannot toggle it. Re-adding the login item to System Settings will fix this issue. |
I've created an PR (sannidhyaroy/pull/33) to address the "launch on login" menu item issue. Tested on macOS Ventura ( |
I used Soduto to share 28 images from my MacBook to my android and it was extremely difficult to know when the transfer was completed. Soduto didn't show any transfer progress bar and on my android device, suddenly the notification centre was bloated with 28 seperate notifications for each image. It would have been possible to monitor the overall transfer progress if there were one or two files being shared but when multiple files are shared, it's incredibly difficult to know. Since, the download task on android is managed by KDE/Zorin Connect, it's probably not possible to do anything on the receiving end. So, I'll share two workarounds on what I think of:
The text was updated successfully, but these errors were encountered: