Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deploying to GHPages #3

Open
affilnost opened this issue Apr 21, 2018 · 4 comments
Open

Improve deploying to GHPages #3

affilnost opened this issue Apr 21, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@affilnost
Copy link
Owner

What we have now

We have now script to deploy the project to "Github Pages":
npm run deploy-to-ghpages
See more at https://github.com/angular-schule/angular-cli-ghpages

What we need

What we need now is to be able to deploy only the last release (the last release tag).
For example, it would be nice to specify the commit hash to deploy, something like this:
npm run deploy-to-ghpages -commit [commit_hash]
or to specify the app version to deploy, like this:
npm run deploy-to-ghpages -version [version_number]
Or maybe just to deploy somehow always the last version. It depends on what will be easier to make.

The main goal is that no "unreleased" version is going to be deployed.

Also the README.md should be updated accordingly.

@affilnost affilnost added enhancement New feature or request good first issue Good for newcomers labels Apr 21, 2018
@hiteshpr
Copy link
Contributor

hiteshpr commented Jun 6, 2018

I can do this.

@affilnost
Copy link
Owner Author

@hiteshpr Sounds great! This issue is reserved for you for now.
If you have any questions, you can write on gitter https://gitter.im/Angular-5-Example-Shopping-App/Lobby
When you're finished, just send a pull-request.

@hiteshpr
Copy link
Contributor

hiteshpr commented Jun 7, 2018

Hi!
I couldn’t find the exact solution.
But, I propose this way -
-- make a gh-pages branch from a particular commit
-- build that branch and deploy it to production/staging.

@affilnost
Copy link
Owner Author

@hiteshpr for the moment running:
npm run deploy-to-ghpages
will deploy the current master to production (github).

We need to improve it, for example by taking a particular commit instead of master.
So when running
npm run deploy-to-ghpages -commit [commit_hash]
it will deploy this exact commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants