@adonisjs/redis - Support multiple subscriptions to one Redis channel

[jonahsnider]

In @adonisjs/redis, trying to do redis.subscribe() when the specified channel already has an active subscription will throw an error.

It would be nice if instead of throwing, @adonisjs/redis was able to intelligently group duplicate subscriptions together.

redis.subscribe('users/123', callback); // opens connection

// later...
redis.subscribe('users/123', callback); // reuses existing subscription

@adonisjs/redis is described as "The package is a thin wrapper on top of ioredis with better DX around Pub/Sub and automatic management of multiple redis connections", so this feature seems very inline with the package's goals.

[thetutlage]

@jonahsnider Yup, I purposely did not add support for it, waiting to see if it is a common use-case and worth supporting or not.

Can you please open an issue with the adonisjs/redis repo and we can work on it. Also, feel free to open a PR, if you think you can write the implementation.

[jonahsnider]

Sure! I originally went to open an issue there but the only allowed template is for a bug report:

Should I just fill that out and have you/someone re-label it after it's created?

[thetutlage]

There is one for "Feature Request"

[thetutlage]

Ohh okay. Ignore the last comment. Yes, go with "Bug report" for now. But I think, we should allow a direct issue for Feature requests too.

[jonahsnider]

Discussion moved to adonisjs/redis#65