Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax issues,- line 54 in config.rasi #179

Open
AnirudhG07 opened this issue Sep 5, 2024 · 4 comments
Open

syntax issues,- line 54 in config.rasi #179

AnirudhG07 opened this issue Sep 5, 2024 · 4 comments

Comments

@AnirudhG07
Copy link

Hi i just installed the cool themes you made. Thanks. But when i run rofi -show window or anything, it gives below error
41afc251-92cb-42db-9bf4-92965fd84059

It seems that the error is in line 54 of config.rasi
I saw and found the issue.

BEFORE

	/*-vv-------- Fallback Icon ----------*/
	run,drun {
		fallback-icon: "application-x-addon";
	}

AFTER

	/*-vv-------- Fallback Icon ----------*/
	run-drun {
		fallback-icon: "application-x-addon";
	}

With this fix, the rofi works properly.

The , in line 54 is purposely there or a bug?
If its a bug, Is it ok if i make a PR and fix it?

@vigneshwaran-48
Copy link

I think it should be handled like this

	run {
		fallback-icon: "application-x-addon";
	}

        drun {
		fallback-icon: "application-x-addon";
	}

@snwfdhmp
Copy link

yes, it should be merged

snwfdhmp added a commit to snwfdhmp/rofi that referenced this issue Nov 14, 2024
@Meqr1
Copy link

Meqr1 commented Nov 19, 2024

please merge this...

@snwfdhmp
Copy link

Made a PR some times ago but @adi1090x is probably busy

#182

Will be fixed once merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants