-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GroupConcat missing filter
parameter
#947
Comments
filter
parameter
Can you check that I might get around to adding this, but if you can try to open a PR that's a much better way of adding this feature. I don't use django-mysql very often these days, as most clients I work with use PostgreSQL. |
I just created a PR with a fix, based on Django Instead of creating the SQL manually, the Django Aggregate compiler is used instead. But that leaves out support for Should someone figure how to do this, then the manual query creation code could probably go entirely. At the moment, it continues to be used when there is no filter expression. |
I've commented on the PR that I was confused by this. Now I see your comment that this was due to lack of time, I won't merge this in its current state. I'd like the filter pathway to be part of the existing compilation code. |
I've added support for ORDER BY and SEPARATOR earlier today. |
Description
Native Django aggregates support a
filter
parameter that allow a subset of expressions to be returned. For example:which generates the following SQL:
However the
filter
parameter is ignored today by GroupConcat and I'm not quite sure how to add it to the source code.The text was updated successfully, but these errors were encountered: