-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully updated and cleaned up, also in Groovy now, with tests. #1
base: master
Are you sure you want to change the base?
Conversation
Cleaned up a few things, also fixed an error in the AZ description.
(Don't worry, I have a whole ton of tests that still pass)
Spock data tables yay!
New standards
Thank you so much for your hard work on this! Weird github didn't email me about an open PR. A couple of pieces of feedback before I'd feel comfortable merging this:
|
Looks like the merge conflicts are due to your recent overhaul of the system. I last touched this a year and a half ago for a project at work, and I'm not terribly interested in it anymore. All I did was clean up the regex in some cases and change the rules in other cases to comply with the 2014 MVR Access and Decoder Digest, as noted in my commit messages. I would assume that our 2 sources for validation rules are in conflict in some cases. You're welcome to verify those rules by looking through my unit tests. I would however question the authoritativeness of NTSI. It may be better to just leave my branch as a fork; my main interest was getting a groovy version that complied with the source we had to use at work. Updating the regex in your format was just a bonus. Feel free to steal my regex, or not, as you see fit. |
Cleaned up a few things, also fixed an error in the AZ description.