Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify exported IDs of a transaction #33

Open
mordax7 opened this issue Sep 12, 2020 · 4 comments
Open

Simplify exported IDs of a transaction #33

mordax7 opened this issue Sep 12, 2020 · 4 comments

Comments

@mordax7
Copy link

mordax7 commented Sep 12, 2020

Description
Since https://github.com/feramhq/transity/blob/master/scripts/helpers.js#L104 function is responsible to simplify the id of the transactions. I was wondering if the idea is that each person extends the mappings by himself or is it worth to create a pull request?
This question came up because I noticed in my transactions.yml had many ids were not readable, duplicates, etc.

@ad-si
Copy link
Owner

ad-si commented Sep 13, 2020

The plan was to have the most common ones already included in Transity, and to provide a file for more local ones (like the barber next door or similar). The feature to provide a file is however not yet implmented.

I'm currently using

npx subf translations.tsv transactions.yaml > fixed.yaml

in my projects.

@ad-si
Copy link
Owner

ad-si commented Sep 13, 2020

So feel free to create a PR if there are some bigger companies you'd like to add!

@mordax7
Copy link
Author

mordax7 commented Sep 14, 2020

I installed your https://github.com/ad-si/subf and it does not recognize my tabs as separators. Do you know what the issue could be? I am using Arch.

@ad-si
Copy link
Owner

ad-si commented Dec 18, 2021

@mordax7 That sounds weird. subf is a quite simple tool, so it should work basically anywhere. Can you give me an example file which does not work for you? Then I can try it out in an arch docker container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants