Future cancellation doesn't seem to works when a client disconnect #3462
Comments
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this issue
Aug 29, 2024
4899: stop trying to process searches after one minute r=ManyTheFish a=irevoire # Pull Request ## Related issue May be related to #4654 and https://github.com/meilisearch/meilisearch-support/issues/350 ## What does this PR do? - If we've been waiting for one whole minute for a search to process, we cancel it - Ideally we should check if the connection was closed instead but that’s not possible currently: actix/actix-web#3462 Co-authored-by: Tamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
I want actix-web to stop processing requests when the client closed the connection.
Current Behavior
It doesn't stop processing the request.
actix-future-cancellation.mp4
Possible Solution
Providing a way to see if the connection is still alive, if that’s even possible with tcp?
Steps to Reproduce (for bugs)
See https://github.com/irevoire/actix-web-future-cancellation-on-timeout
Context
In Meilisearch we cannot process more search requests than we have core.
But we don't want to refuse search requests when all cores are used, which means we have to store a queue of search requests to process.
Sometimes users have searches that can take a few seconds to process.
When this happens, emptying the queue takes time. But it shouldn’t since most clients will disconnect after waiting for a few seconds.
When the queue gives us a permit to process a new search requests, I would like to check if a client is still connected before doing any extra work.
Your Environment
rustc -V): rustc 1.78.0 (9b00956e5 2024-04-29)The text was updated successfully, but these errors were encountered: