payment icons updated #413

maunaw · 2021-02-11T06:26:24Z

** Checklist **

All icons have a corresponding entry in db/payment_icons.yml
I have followed the icon guidelines detailed in the CONTRIBUTING.md file
I have optimized the icon with SVGO
I am confident that all icons are clear and easy to read/understand
I have provided a link to the brand icon’s brand guidelines whenever possible.

If this pull request is not adding new icons, you can remove this checklist.

Resolves #417

larouxn

There are a few issues we need to address.

Mastercard does not need to be added, it already exists as master.
Why are we updating PayPal, Visa, and Maestro? Seems unnecessary. (also weird spacing)
Why are we updating the Afterpay icon? It's currently correct according to https://www.afterpay.com. Do we need a new afterpay icon for a different similarly named service?
Why is the Swish icon update blank? (pure white)
Why do all icons have an empty space towards the bottom? (see below)

maunaw · 2021-02-18T06:12:25Z

There are a few issues we need to address.

Mastercard does not need to be added, it already exists as master.

Why are we updating PayPal, Visa, and Maestro? Seems unnecessary. (also weird spacing)

Why are we updating the Afterpay icon? It's currently correct according to https://www.afterpay.com. Do we need a new afterpay icon for a different similarly named service?

Why is the Swish icon update blank? (pure white)

Why do all icons have an empty space towards the bottom? (see below)

Hi, @larouxn Thank you for the response. Changes have been made as per suggestions. Can you please take a look at latest commits?

larouxn · 2021-02-22T02:40:28Z

👋 Hey @maunaw, can we do the following?

Remove the changes to Afterpay, Maestro, PayPal, and Visa
Remove the new, unnecessary Mastercard SVG
Fix all of the added/updated icons so they have the proper 7% visible gray border (guidelines | template)
Run SVGO on all of the added/updated icons (step 5 in here)

momai-nets · 2021-02-24T08:05:33Z

Hi Nicholas,
Thank you for your feedback.

Remove the changes to Afterpay, Maestro, PayPal, and Visa
Remove the new, unnecessary Mastercard SVG
****- Former versions did not follow the guideline fully because of transparent background. Therefore we are surprised by this**** comment
Fix all of the added/updated icons so they have the proper 7% visible gray border (guidelines | template)

- All icons consists of background#fff and 1px border #000 0.07transparency border-radius 2px ??
Run SVGO on all of the added/updated icons (step 5 in here)
- Please check content of SVG files. All files are fully optimized.

larouxn · 2021-02-24T10:03:31Z

👋 Hello @momai-nets, the updated Afterpay icon is still the wrong icon. It should be the icon for afterpay.com. Additionally, Maestro and other icons are still less tall for some reason. This is not desirable. Can we please remove the Afterpay, Maestro, PayPal, and Visa changes as well as the added Mastercard icon?

Additionally it seems the updated icons do not seem to have the proper border style.

The Visa icon can be used as a guideline. Newly added/updated icons should adhere to this style. If we look carefully, we can see the updated icons do not have the same border style as the grey border is visible upon the black background.

Lastly, I feel SVGO likely has not been run on the icons as SVGO compresses icons to a single line, whereas all of these updated/added icons are multi-line. Though, this is the least of my concerns.

All of that said, I am somewhat okay the changes to the icons other than Afterpay, Maestro, PayPal, Visa, and Mastercard.

momai-nets · 2021-02-25T09:40:25Z

Arh Thank you Nicolas,
I see the issue now from your screenshots. The batch of icons you are working with are NOT the latest batch where we have fixed all issues and followed the guidelines fully. We will look into it.

maunaw · 2021-03-03T06:23:51Z

@larouxn We have updated the icons running SVGO and restoring old ones. Request you to please review the updated icons with latest commit. Kindly let us know if anything. Thank you.

larouxn · 2021-03-03T14:09:25Z

👋 I will try to take a look at this tomorrow. In the meantime, can we remove the mastercard.svg? There's already an icon available at master.svg.

https://github.com/activemerchant/payment_icons/blob/2c77ec6a6d17ab352b411b4d8b5411b2b82e95b2/app/assets/images/payment_icons/master.svg

maunaw · 2021-03-03T14:18:37Z

👋 I will try to take a look at this tomorrow. In the meantime, can we remove the mastercard.svg? There's already an icon available at master.svg.

https://github.com/activemerchant/payment_icons/blob/2c77ec6a6d17ab352b411b4d8b5411b2b82e95b2/app/assets/images/payment_icons/master.svg

Sure, removed mastercard.svg. Thank you.

larouxn

Thanks for cleaning this up! Looking good.

@tauthomas01, can you take a look?

app/assets/images/payment_icons/dankort.svg

app/assets/images/payment_icons/mobilepay.svg

app/assets/images/payment_icons/ratepay.svg

app/assets/images/payment_icons/swish.svg

app/assets/images/payment_icons/vipps.svg

Co-authored-by: tauthomas01 <[email protected]>

maunaw · 2021-03-08T06:10:28Z

@tauthomas01 Thank you. Suggested changes are committed to this PR. Request you to please review.

tauthomas01

Hi,

I left some comments.

Please let me know if there are any questions.

tauthomas01 · 2021-03-08T14:37:32Z

app/assets/images/payment_icons/dankort.svg

The border style needs to follow like other icons

Please follow the contributions guideline

You can follow this example icon as a reference.

app/assets/images/payment_icons/mobilepay.svg

app/assets/images/payment_icons/ratepay.svg

app/assets/images/payment_icons/swish.svg

app/assets/images/payment_icons/vipps.svg

nrbar · 2021-03-24T09:49:14Z

We have updated the icons. Request you to please review the updated icons with latest commit. Kindly let us know if anything. Thank you.

larouxn · 2021-03-26T07:34:22Z

app/assets/images/payment_icons/visa.svg

+<path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/>
+<path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/>
+</svg>


Can we please remove these changes to visa.svg?

larouxn · 2021-03-26T07:34:43Z

app/assets/images/payment_icons/paypal.svg

+<path fill="#3086C8" d="M23.9 8.3l-.2.2c-.5 2.8-2.2 3.8-4.6 3.8H18c-.3 0-.5.2-.6.5l-.6 3.9-.2 1c0 .2.1.4.3.4H19c.3 0 .5-.2.5-.4v-.1l.4-2.4v-.1c0-.2.3-.4.5-.4h.3c2.1 0 3.7-.8 4.1-3.2.2-1 .1-1.8-.4-2.4-.1-.5-.3-.7-.5-.8z"/>
+<path fill="#012169" d="M23.3 8.1c-.1-.1-.2-.1-.3-.1-.1 0-.2 0-.3-.1-.3-.1-.7-.1-1.1-.1h-3c-.1 0-.2 0-.2.1-.2.1-.3.2-.3.4l-.7 4.4v.1c0-.3.3-.5.6-.5h1.3c2.5 0 4.1-1 4.6-3.8v-.2c-.1-.1-.3-.2-.5-.2h-.1z"/>
+</svg>


Can we please remove these changes to paypal.svg?

larouxn · 2021-03-26T07:35:04Z

app/assets/images/payment_icons/mastercard.svg

+<circle fill="#EB001B" cx="15" cy="12" r="7"/>
+<circle fill="#F79E1B" cx="23" cy="12" r="7"/>
+<path fill="#FF5F00" d="M22,12c0-2.4-1.2-4.5-3-5.7c-1.8,1.3-3,3.4-3,5.7s1.2,4.5,3,5.7C20.8,16.5,22,14.4,22,12z"/>
+</svg>


Can we please remove this duplicate mastercard.svg? (already one under master.svg)

larouxn · 2021-03-26T07:35:23Z

app/assets/images/payment_icons/maestro.svg

+<circle fill="#00A2E5" cx="23" cy="12" r="7"/>
+<path fill="#7375CF" d="M22 12c0-2.4-1.2-4.5-3-5.7-1.8 1.3-3 3.4-3 5.7s1.2 4.5 3 5.7c1.8-1.2 3-3.3 3-5.7z"/>
+</svg> 


Can we please remove these changes to maestro.svg?

larouxn · 2021-03-26T07:36:29Z

app/assets/images/payment_icons/afterpay.svg

+	c0.366-0.183,0.731,0.092,0.731,0.458v0.366c0,1.921,2.105,3.11,3.753,2.195l2.47-1.464l2.47-1.464
+	C28.293,10.628,28.293,8.249,26.645,7.242z"/>
+</svg>


Can we please remove these changes to afterpay.svg?

Source: https://www.afterpay.com/index

larouxn · 2021-03-26T07:40:43Z

app/assets/images/payment_icons/mobilepay.svg

+	L11.614,7.892c-0.13-0.337-0.125-0.68,0.016-1.028c0.141-0.337,0.386-0.582,0.734-0.734l4.879-2.023
+	c0.359-0.142,0.702-0.142,1.028,0C18.631,4.258,18.881,4.503,19.023,4.84z"/>
+</svg>


May be able to drop this change in favour of #424.

maunaw · 2021-05-07T06:36:57Z

Closing this pull request as created a new one with exact changes required.

maunaw added 10 commits February 11, 2021 11:19

payment icons updated

3c7b336

yaml file updated

93aacc4

maestro svg updated

2216664

payment icons svg changes

f7106a0

title value changes

a704d8a

id changes for tags inside

7437406

added role attribute

bfbb8e6

title changes

55665cd

swish svg changes

0f971b5

title change

16b5da5

maunaw mentioned this pull request Feb 16, 2021

payment icons updated #417

Open

larouxn requested review from larouxn and tauthomas01 February 16, 2021 07:35

larouxn requested changes Feb 16, 2021

View reviewed changes

maunaw added 2 commits February 18, 2021 11:33

payment icons updated

899f0f0

title corrected for icons

08e8f3e

maunaw requested a review from larouxn February 18, 2021 06:12

restore old icons and added new with svgo

20857cf

Delete mastercard.svg

71815e3

larouxn approved these changes Mar 5, 2021

View reviewed changes

tauthomas01 requested changes Mar 5, 2021

View reviewed changes

Update app/assets/images/payment_icons/dankort.svg

f5748a8

Co-authored-by: tauthomas01 <[email protected]>

maunaw and others added 4 commits March 8, 2021 11:36

Update app/assets/images/payment_icons/mobilepay.svg

faa9d13

Co-authored-by: tauthomas01 <[email protected]>

Update app/assets/images/payment_icons/swish.svg

d75d38a

Co-authored-by: tauthomas01 <[email protected]>

Update app/assets/images/payment_icons/ratepay.svg

6360c35

Co-authored-by: tauthomas01 <[email protected]>

Update app/assets/images/payment_icons/vipps.svg

92d76ab

Co-authored-by: tauthomas01 <[email protected]>

maunaw requested a review from tauthomas01 March 8, 2021 11:21

tauthomas01 requested changes Mar 8, 2021

View reviewed changes

payment icons added and updated

b04c306

larouxn requested changes Mar 26, 2021

View reviewed changes

maunaw and others added 3 commits April 26, 2021 19:27

corrected updated payment icons

40834e8

corrected updated payment icons

4ef819c

Merge branch 'master' into nets_easy_icon

7cbaaac

maunaw marked this pull request as draft May 7, 2021 05:52

maunaw closed this May 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

payment icons updated #413

payment icons updated #413

maunaw commented Feb 11, 2021 •

edited by larouxn

Loading

larouxn left a comment

maunaw commented Feb 18, 2021 •

edited

Loading

larouxn commented Feb 22, 2021

momai-nets commented Feb 24, 2021 •

edited

Loading

larouxn commented Feb 24, 2021

momai-nets commented Feb 25, 2021

maunaw commented Mar 3, 2021

larouxn commented Mar 3, 2021

maunaw commented Mar 3, 2021

larouxn left a comment

maunaw commented Mar 8, 2021

tauthomas01 left a comment

tauthomas01 Mar 8, 2021

nrbar commented Mar 24, 2021

larouxn Mar 26, 2021

larouxn Mar 26, 2021

larouxn Mar 26, 2021

larouxn Mar 26, 2021

larouxn Mar 26, 2021

larouxn Mar 26, 2021

maunaw commented May 7, 2021

payment icons updated #413

payment icons updated #413

Conversation

maunaw commented Feb 11, 2021 • edited by larouxn Loading

larouxn left a comment

Choose a reason for hiding this comment

maunaw commented Feb 18, 2021 • edited Loading

larouxn commented Feb 22, 2021

momai-nets commented Feb 24, 2021 • edited Loading

larouxn commented Feb 24, 2021

momai-nets commented Feb 25, 2021

maunaw commented Mar 3, 2021

larouxn commented Mar 3, 2021

maunaw commented Mar 3, 2021

larouxn left a comment

Choose a reason for hiding this comment

maunaw commented Mar 8, 2021

tauthomas01 left a comment

Choose a reason for hiding this comment

tauthomas01 Mar 8, 2021

Choose a reason for hiding this comment

nrbar commented Mar 24, 2021

larouxn Mar 26, 2021

Choose a reason for hiding this comment

larouxn Mar 26, 2021

Choose a reason for hiding this comment

larouxn Mar 26, 2021

Choose a reason for hiding this comment

larouxn Mar 26, 2021

Choose a reason for hiding this comment

larouxn Mar 26, 2021

Choose a reason for hiding this comment

larouxn Mar 26, 2021

Choose a reason for hiding this comment

maunaw commented May 7, 2021

maunaw commented Feb 11, 2021 •

edited by larouxn

Loading

maunaw commented Feb 18, 2021 •

edited

Loading

momai-nets commented Feb 24, 2021 •

edited

Loading