Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forte: update to v3 api #3642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

wsmoak
Copy link
Contributor

@wsmoak wsmoak commented May 22, 2020

Update the Forte gateway to the new v3 API: https://restdocs.forte.net/?version=latest

  • In the endpoint URI, change v2 to v3
  • In the endpoint URI, change /accounts to /organizations
  • In the X-Forte-Auth header change “Account” to “Organization”
  • Allow either organization_id or account_id to be used for configuration for backwards compatibility
  • Instead of act_XXXXXX use org_XXXXXX
  • remove the unused check_number attribute
  • change the 'disburse' action to 'credit'

Fixes: #3614

Unit:
20 tests, 67 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
22 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@wsmoak
Copy link
Contributor Author

wsmoak commented May 22, 2020

There are some pre-existing failures in the remote tests because the sec_code attribute is now required. See #3640 for that fix.

Current status:

Remote:
21 tests, 58 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
90.4762% passed

Unit: 20 tests, 67 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@wsmoak
Copy link
Contributor Author

wsmoak commented May 26, 2020

After merging in master to pick up the sec_code fix in #3640, (and then fixing what I broke while resolving the conflict) the test results are:

Unit:
20 tests, 67 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
22 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

And apparently I have been using Github's "Squash and Merge" feature for long enough that I'm not entirely sure how to get this squashed back down to a single commit. I will try again soon.

Update the Forte gateway to the new v3 API:  https://restdocs.forte.net/?version=latest

* In the endpoint URI, change v2 to v3
* In the endpoint URI, change /accounts to /organizations
* In the X-Forte-Auth header change “Account” to “Organization”
* Allow either organization_id or account_id to be used for configuration for backwards compatibility
* Instead of act_XXXXXX use org_XXXXXX
* remove the unused check_number attribute
* change the 'disburse' action to 'credit'

Fixes: activemerchant#3614

Unit:
20 tests, 67 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
22 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@wsmoak
Copy link
Contributor Author

wsmoak commented May 26, 2020

It is now squashed to a single commit with test results in the commit message.

Copy link

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!

@github-actions github-actions bot added the Stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Forte to the v3 api
1 participant