Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Tencent Kona JDK #671

Open
johnshajiang opened this issue Aug 14, 2024 · 3 comments
Open

Support Tencent Kona JDK #671

johnshajiang opened this issue Aug 14, 2024 · 3 comments
Labels
feature request New feature or request to improve the current logic

Comments

@johnshajiang
Copy link
Contributor

johnshajiang commented Aug 14, 2024 •
edited
Loading

Description:
Tencent is one of main OpenJDK contributors, and it has its own OpenJDK distro, exactly Tencent Kona JDK.
We'd like to see setup-java support this distro as well.

Justification:
GitHub Java projects can easily apply Tencent Kona JDK with GitHub Actions.

Are you willing to submit a PR?
Sure
@johnshajiang johnshajiang added feature request New feature or request to improve the current logic needs triage labels Aug 14, 2024
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this issue Aug 14, 2024
@johnshajiang
Support Tencent Kona JDK (actions#671)
9871695
@johnshajiang johnshajiang mentioned this issue Aug 14, 2024
Open
2 tasks
@priyagupta108
Copy link

Hi @johnshajiang 👋,
Thank you for the feature request. We'll investigate it and get back to you as soon as we have updates.

@johnshajiang
Copy link
Contributor Author

Thanks for triaging this issue!

I already submitted the PR #672 for this feature, please take a look at it as well.

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this issue Sep 12, 2024
@johnshajiang
Support Tencent Kona JDK (actions#671)
a8506e9
@johnshajiang
Copy link
Contributor Author

I just updated the commit in PR #672 for supporting Kona JDK 21 and resolving the file conflicts.
Please review this PR.
Please feel free to raise your concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnshajiang @priyagupta108