Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNAME file doesn't work to set custom domain #304

Open
scriptype opened this issue Jan 24, 2024 · 1 comment
Open

CNAME file doesn't work to set custom domain #304

scriptype opened this issue Jan 24, 2024 · 1 comment

Comments

@scriptype
Copy link

scriptype commented Jan 24, 2024

Hi, I'm actually not sure if this is the right place for this issue, but here it is.

I've recently switched the pages setting of my repository to use github actions:

image

When I was using the "deploy from a branch" option, GitHub was automatically seeing the cname file in the docs folder (pages folder) to set up custom domain. This was useful because the file was being automatically generated based on static site generator configuration.

I have noticed this cname file is no longer useful since I switched to using actions/deploy-pages. It would be sweet if cname file just worked like before, or alternatively, if the action had an input for cname.

Just to be clear, the problem is having to enter the custom domain by hand in the github pages settings UI when using actions/deploy-pages.

scriptype referenced this issue in scriptype/writ Jan 24, 2024
Because apparently a cname file in the deployment artifacts of the gh-action doesn't automatically work like it did before when deployment was done from a directory in master branch
@EvanCarroll
Copy link

I had the same problem having uploaded a CNAME file, here was my solution https://devops.stackexchange.com/a/19892/18965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants