db transaction issue

[CrossLee]

sample code:

@With(BeetlSqlTransactional.class)
    public void test() {
    mapper1.insert(obj1);
mapper2.insert(obj1);

// 只要加了类似下面的Response操作，上面的insert就不会提交（很有可能是回滚了）
H.Response response=
response.contentType("text/html;charset=" + ZhifubaoConstants.CHARSET);
            response.writeHtml(form);
            response.close();

}

[javamonkey]

这是为啥呢，beetlsql不会主动提交事务导致的，不过应该是@with(BeetlSqlTransactional.class)没有发挥作用？

//SQLScript.java
 protected void clean(boolean isUpdate, Connection conn, PreparedStatement ps, ResultSet rs) {
        try {
            if (rs != null)
                rs.close();
            if (ps != null)
                ps.close();
            if (!this.sm.getDs().isTransaction()) {
                try {

                    if (conn != null) {
                        // colse 不一定能保证能自动commit
                        if (isUpdate && !conn.getAutoCommit()) {

                            conn.commit();
                        }

                        conn.close();
                    }
                } catch (SQLException e) {
                    throw new BeetlSQLException(BeetlSQLException.SQL_EXCEPTION, e);
                }

            }
        } catch (SQLException e) {
            // ignore
        }
    }

this.sm.getDs().isTransaction() 用来判断是否是否在事务环境，一般跟web框架集成，都会返回true
这样，等待web框架主动commit

[greenlaw110]

@CrossLee BeetlSqlTransactional is a After interceptor:

However because you have already closed the response, therefore After interceptor will no longer be executed:

Solution, use @act.db.sql.tx.Transactional to replace @With(BeetlSqlTransactional.class):

say, the following code will make sure TX get committed:

        @Transactional
        public void update2(Integer id, String name, H.Response resp) {
            doUpdate(id, name);
            resp.contentType("text/plaintext");
            resp.writeText("done");
            resp.close();
        }

[CrossLee]

@greenlaw110 是不是@transactional 都可以替代@with(BeetlSqlTransactional.class)？

[greenlaw110]

yes

…

On Thu, Apr 2, 2020 at 3:11 PM Cross Lee ***@***.***> wrote: @greenlaw110 <https://github.com/greenlaw110> ***@***.*** <https://github.com/transactional> ***@***.*** <https://github.com/with> (BeetlSqlTransactional.class)？ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABU6YV3ZWFVYIGIASUPPWTRKQF7VANCNFSM4LWRJ6MQ> .