Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] moving repo to kysely-org #23

Open
marcosrjjunior opened this issue Apr 19, 2024 · 1 comment
Open

[suggestion] moving repo to kysely-org #23

marcosrjjunior opened this issue Apr 19, 2024 · 1 comment

Comments

@marcosrjjunior
Copy link
Contributor

marcosrjjunior commented Apr 19, 2024

hey @acro5piano

we were discussing on kysely channel, the possibility of moving this repo to the organisation and so we could start a kysely-cli, that could potentially be extended/improved to include other scripts.
Having a repo inside the organisation has many benefits, including more support and trust.

initially we would have the migration script and run something like:

kysely migration up | down | ...

channel discussion

would you be interested on this migration?

@acro5piano
Copy link
Owner

acro5piano commented Apr 19, 2024

Hi @marcosrjjunior, thank you for your suggestion! I've read the related chat on Discord and I'm glad to hear that this repository is somewhat useful to Kysely community.

I'm truly positive to move this repository under the official org. Here are some thoughts though:

  • The command-line interface. This library does not provide a command interface respecting Kysely's intention not to confuse TypeScript users. So your suggestion might differ from the following philosophy:

This is because Kysely's migrations are also written in TypeScript. To run the migrations, you need to first build the TypeScript code into JavaScript. A CLI would cause confusion over which migrations are being run, the TypeScript ones or the JavaScript ones

I'm not sure whether we should provide the command interface or not. However, as you might know this library has experimental support of the command interface, so if Kysely team suggests it I'm totally agree to it.

  • License. I want to keep my name in README and LICENSE as a OSS developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants