Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to suspend scaling operations during code deployment #112

Open
pdrakeweb opened this issue Jul 21, 2016 · 2 comments
Open

Option to suspend scaling operations during code deployment #112

pdrakeweb opened this issue Jul 21, 2016 · 2 comments

Comments

@pdrakeweb
Copy link
Contributor

It would be nice if there was an option to suspend scaling operations on the ASG during code deployment / stack update. It would also be nice if these operations could be suspended during initial deployment so that a long grace period is not required in order to use an ELB health check.

@askreet
Copy link
Contributor

askreet commented Sep 28, 2016

I wonder if this is as big of a concern as we think? From Health Checks for Auto Scaling Groups:

"Note that if you add a lifecycle hook to perform actions as your instances launch, the health check grace period does not start until the lifecycle hook is completed and the instance enters the InService state."

This should, in theory, include CodeDeploy -- so where have you seen that long health check grace periods are required?

@pdrakeweb
Copy link
Contributor Author

This would be nice for development because if you deploy broken code (successful deploy, broken functionally) the ASG may terminate your instance shortly thereafter, making it difficult to debug. CodeDeploy will then proceed to deploy the broken code to every replacement instance, which the ASG will then proceed to terminate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants