Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x branch is not installable on Mautic 5 RC1 or RC2 #330

Open
1 task done
driskell opened this issue Dec 19, 2023 · 9 comments
Open
1 task done

5.x branch is not installable on Mautic 5 RC1 or RC2 #330

driskell opened this issue Dec 19, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@driskell
Copy link

Mautic Version

4.2.x series

PHP version

8.1.26

What browsers are you seeing the problem on?

Not relevant

What happened?

When attempting to install using composer the Mautic 5 RC1, and using @5.x for this repository, the composer install fails because the 5.x branch's composer.json still references Mautic 4 core/lib as a requirement.

It would be great to understand when a 5.x version will be ready now that there is an announcement date of Mautic 5 for early January. It does look like 5.x has been worked on but it's confusing as it still requires Mautic 4 in the composer.json so it's not actually usable at all.

How can we reproduce this issue?

Step 1: Setup Mautic 5 RC1 using composer
Step 2: Add this plugin repository to composer.json using @5.x, adjusting minimum stability to dev
Step 3: Run composer install

Relevant log output

No response

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct
@driskell driskell added the bug Something isn't working label Dec 19, 2023
@driskell
Copy link
Author

Happy to do a PR etc. but I would like to just check first that 5.x is the target branch for the 5.x release, and also understand what status that branch is in, before I start any work that might be incorrect or even potentially already done and just not yet merged or pushed.

@escopecz
Copy link
Contributor

There will be more changes needed to support M5. There are already open PRs for that:

https://github.com/acquia/mc-cs-plugin-custom-objects/pulls

We do not have a process to review and test these PRs internally but we are working on that.

@adamchemiawppl
Copy link

Is there any timeline on when Custom Objects will be compatiblle with Mautic 5.x?

@escopecz
Copy link
Contributor

Ideally, it should be available in #338 but may need some final touches.

@adamchemiawppl
Copy link

Thanks! Installed fork on my dev system, seems to work fine. In case of any bugs - will let you know.

@stepcellwolf
Copy link

@adamchemiawppl which branch did you used for Mautic 5.x?

@adamchemiawppl
Copy link

@adamchemiawppl which branch did you used for Mautic 5.x?

Exactly the one escopecz recommeended: https://github.com/volha-pivavarchyk/mc-cs-plugin-custom-objects/tree/update-to-5x

@mehransobhani
Copy link

"I am having trouble installing this plugin on version 5.1. When will this issue be resolved?"

@escopecz
Copy link
Contributor

It will be resolved once this comment will be addressed and at least 2 community members will approve the pull request. The work doesn't have to wait for Volha to do. Anyone can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants