Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRS is not compatible with BLT making migration not possible #75

Open
korkhau opened this issue Nov 20, 2024 · 0 comments
Open

DRS is not compatible with BLT making migration not possible #75

korkhau opened this issue Nov 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@korkhau
Copy link

korkhau commented Nov 20, 2024

Describe the bug
BLT allowed for configuration overrides; for example, we had init disabled:

disable-targets:
  blt:
    shell-alias:
      init: true

To Reproduce

  1. Install with composer install
  2. See settings added into /default/settings.php
require DRUPAL_ROOT . "/../vendor/acquia/drupal-recommended-settings/settings/acquia-recommended.settings.php";
/**
 * IMPORTANT.
 *
 * Do not include additional settings here. Instead, add them to settings
 * included by `acquia-recommended.settings.php`. See Acquia's documentation for more detail.
 *
 * @link https://docs.acquia.com/
 */

Expected behavior
By using /drs/config.yml we should be able to disable running of /bin/drush drs:init:settings on composer install as it is in BLT

Additional context
onPostCmdEvent does not take into account any properties from config at all:

  /**
   * Includes Acquia recommended settings post composer update/install command.
   */
  public function onPostCmdEvent(): void {
    // Only install the template files, if the drupal-recommended-settings
    // plugin is installed, with drupal project.
    if ($this->settingsPackage && $this->getDrupalRoot() && !$this->bltUpdated) {
      $vendor_dir = $this->composer->getConfig()->get('vendor-dir');
      $this->executeCommand(
        $vendor_dir . "/bin/drush drs:init:settings", [],
        TRUE
      );
    }
  }
@korkhau korkhau added the bug Something isn't working label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant