Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incopmatibility from BLT: The default value of $drs_override_config_directories is different from BLT's #72

Open
nsfisis opened this issue Sep 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@nsfisis
Copy link

nsfisis commented Sep 19, 2024

Describe the bug

The default value of $drs_override_config_directories is different from $blt_override_config_directories.

BLT:

https://github.com/acquia/blt/pull/4709/files#diff-f9a40a07d9a773b708777ca2e41c24519280d8ffc19f7379b56e2587d8e389ef

if (!isset($blt_override_config_directories)) {
  $blt_override_config_directories = TRUE;
}

If $blt_override_config_directories is not set, it is set to TRUE.

Drupal Recommended Settings:

https://github.com/acquia/drupal-recommended-settings/blob/60a053a057e5b80fcb83c559ce8c5479f665eaaf/settings/config.settings.php

$drs_override_config_directories = $drs_override_config_directories ?? FALSE;

If $drs_override_config_directories is not set, it is set to FALSE.

To Reproduce

N/A

Expected behavior

According to the source code comment,

/**
 * Override config directories.
 *
 * Acquia Drupal Recommended Settings makes the assumption that,
 * if using multisite, the default configuration
 * directory should be shared between all multi-sites, and each multisite will
 * override this selectively using configuration splits. However, some
 * applications may prefer to manage the configuration for each multisite
 * completely separately. If this is the case,
 * set FALSE to $drs_override_config_directories
 * and $drs_override_site_studio_sync_directories
 * $settings['config_sync_directory'] = $dir . "/config/$site_dir"
 * $settings['site_studio_sync'] =  $dir . "/sitestudio/$site_dir" in
 * settings.php, and we will not overwrite it.
 */

setting FALSE to $drs_override_config_directories seems an exceptional case. Thus, the default value of it is expected to be TRUE as it is in BLT.

If this change is intended, it should be mentioned in the migration guide: https://dev.acquia.com/tutorial/you-dont-need-blt-acquia-cloud.

Screenshots

N/A

Environment

DRS v1.0.1 (the latest version).

Additional context

No.

@nsfisis nsfisis added the bug Something isn't working label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant