Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect splitting of kernel modules names #200

Open
mbrysa opened this issue Nov 26, 2014 · 3 comments
Open

Incorrect splitting of kernel modules names #200

mbrysa opened this issue Nov 26, 2014 · 3 comments
Assignees

Comments

@mbrysa
Copy link
Contributor

mbrysa commented Nov 26, 2014

Kernel module names are not split when separated by "\n"

{   "ureport_version": 2
,   "reason": "Kernel oops in __d_lookup_rcu"
,   "reporter": {   "name": "satyr"
                ,   "version": "0.14"
                }
,   "os": {   "name": "fedora"
          ,   "version": "20"
          ,   "architecture": "x86_64"
          ,   "cpe": "cpe:/o:fedoraproject:fedora:20"
          }
,   "problem": {   "type": "kerneloops"
               ,   "component": "kernel"
               ,   "raw_oops": "general protection fault: 0000 [#3] SMP \nModules linked in: nf_conntrack_netbios_ns nf_conntrack_broadcast ip6t_rpfilter ip6t_REJECT cfg80211 rfkill xt_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw it87 hwmon_vid snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep fuse snd_seq snd_seq_device snd_pcm snd_timer ppdev parport_pc iTCO_wdt iTCO_vendor_support joydev x86_pkg_temp_thermal coretemp snd kvm_intel tpm_tis ses tpm_infineon enclosure lpc_ich kvm parport mei_me i2c_i801 mei soundcore\nshpchp\nserio_raw\nmfd_core\ncrct10dif_pclmul\ncrc32_pclmul\ncrc32c_intel\nghash_clmulni_intel\ntpm\nvideo\nbinfmt_misc\nuas\nusb_storage\nradeon\ni2c_algo_bit\ndrm_kms_helper\nttm\ndrm\nr8169\nmii\nCPU: 1 PID: 11541 Comm: abrt-action-sav Tainted: G      D        3.17.3-200.fc20.x86_64 #1\nHardware name: Gigabyte Technology Co., Ltd. Z87M-D3H/Z87M-D3H, BIOS 11b 06/12/2014\ntask: ffff88020af689d0 ti: ffff8801c269c000 task.ti: ffff8801c269c000\nRIP: 0010:[<ffffffff8121a7f0>] \n[<ffffffff8121a7f0>] __d_lookup_rcu+0x80/0x160\n"
               ,   "version": "3.17.3-200.fc20.x86_64"
               ,   "taint_flags": [ "died_recently" ]
               ,   "modules":
                     [ "nf_conntrack_netbios_ns"
                     , "nf_conntrack_broadcast"
                     , "ip6t_rpfilter"
                     , "ip6t_REJECT"
                     , "cfg80211"
                     , "rfkill"
                     , "xt_conntrack"
                     , "ebtable_nat"
                     , "ebtable_broute"
                     , "bridge"
                     , "stp"
                     , "llc"
                     , "ebtable_filter"
                     , "ebtables"
                     , "ip6table_nat"
                     , "nf_conntrack_ipv6"
                     , "nf_defrag_ipv6"
                     , "nf_nat_ipv6"
                     , "ip6table_mangle"
                     , "ip6table_security"
                     , "ip6table_raw"
                     , "ip6table_filter"
                     , "ip6_tables"
                     , "iptable_nat"
                     , "nf_conntrack_ipv4"
                     , "nf_defrag_ipv4"
                     , "nf_nat_ipv4"
                     , "nf_nat"
                     , "nf_conntrack"
                     , "iptable_mangle"
                     , "iptable_security"
                     , "iptable_raw"
                     , "it87"
                     , "hwmon_vid"
                     , "snd_hda_codec_realtek"
                     , "snd_hda_codec_generic"
                     , "snd_hda_codec_hdmi"
                     , "snd_hda_intel"
                     , "snd_hda_controller"
                     , "snd_hda_codec"
                     , "snd_hwdep"
                     , "fuse"
                     , "snd_seq"
                     , "snd_seq_device"
                     , "snd_pcm"
                     , "snd_timer"
                     , "ppdev"
                     , "parport_pc"
                     , "iTCO_wdt"
                     , "iTCO_vendor_support"
                     , "joydev"
                     , "x86_pkg_temp_thermal"
                     , "coretemp"
                     , "snd"
                     , "kvm_intel"
                     , "tpm_tis"
                     , "ses"
                     , "tpm_infineon"
                     , "enclosure"
                     , "lpc_ich"
                     , "kvm"
                     , "parport"
                     , "mei_me"
                     , "i2c_i801"
                     , "mei"
                     , "soundcoreshpchpserio_rawmfd_corecrct10dif_pclmulcrc32_pclmulcrc32c_intelghash_clmulni_inteltpmvideobinfmt_miscuasusb_storageradeoni2c_algo_bitdrm_kms_helperttmdrmr8169mii" ]
               ,   "frames":
                     [ {   "address": 18446744071581050864
                       ,   "reliable": true
                       ,   "function_name": "__d_lookup_rcu"
                       ,   "function_offset": 128
                       ,   "function_length": 352
                       ,   "from_function_offset": 0
                       ,   "from_function_length": 0
                       } ]
               }
,   "packages": [ {   "name": "kernel"
                  ,   "epoch": 0
                  ,   "version": "3.17.3"
                  ,   "release": "200.fc20"
                  ,   "architecture": "x86_64"
                  ,   "package_role": "affected"
                  } ]
}
@arhledvink
Copy link
Contributor

satyr
lib/report.c
sr_report_to_json

@jfilak
Copy link
Contributor

jfilak commented Aug 16, 2016

libreport/reporter-ureport
    libreport/ureport_from_dump_dir_ext()
        satyr/sr_abrt_report_from_dir()
            stayr/sr_koops_stacktrace_parse()
                stayr/sr_koops_stacktrace_parse_modules()
        satyr/sr_report_to_json()

@xsuchy xsuchy added the bug label May 11, 2017
juliusmilan added a commit to juliusmilan/satyr that referenced this issue Dec 4, 2017
@juliusmilan
Copy link
Contributor

the problem is that journal splits long lines without preserving trailing space, then is not possible to determine if "abcd" and "efgh" was previously 2 words or 1 word and causes wrong parsing of kernel module names in rare situations, for more details see:
https://bugzilla.redhat.com/show_bug.cgi?id=1520450
kernel always writes those modules in a single line (procedure print_modules is the only place where modules are printed):
https://github.com/torvalds/linux/blob/master/kernel/module.c#L4355

@xsuchy xsuchy added the on hold label Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants