Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run update tests on releases #455

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Don't run update tests on releases #455

merged 1 commit into from
Sep 10, 2024

Conversation

abelsiqueira
Copy link
Collaborator

The update tests try to compare two versions of the generated
package. Since the release is done form the main branch, this
test can't run properly.
This PR checks if the GitHub CI event is release, and don't
run the test if it is.

Can only be properly tested with a new release.

Related to #454

The update tests try to compare two versions of the generated
package. Since the release is done form the main branch, this
test can't run properly.
This PR checks if the GitHub CI event is release, and don't
run the test if it is.

Can only be properly tested with a new release.

Related to #454
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (825b53d) to head (620ee68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #455   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           99        99           
=========================================
  Hits            99        99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira merged commit ebc72c4 into main Sep 10, 2024
7 checks passed
@abelsiqueira abelsiqueira deleted the 454-fix-test branch September 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant