Don't create main branch when on main and don't run some tests on main #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReusableTest workflow creates a main branch due a specific test recently introduced. That specific runs the generation on main and on HEAD. Both activites make no sense if we are running on the main branch. This creates a condition on the workflow to only run if the branch is not main (a condition on PRs would also work, but we leave the possibility of running tests on others branches with this approach). Furthermore, this also adds a condition in the tests such that only on main the tests are run. Closes #435
abelsiqueira
force-pushed
the
435-fix-tests
branch
from
c8329b0
to
38f1f6f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 104 104
=========================================
Hits 104 104 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReusableTest workflow creates a main branch due a specific
test recently introduced. That specific runs the generation on main
and on HEAD.
Both activites make no sense if we are running on the main branch,
This creates a condition on the workflow to only run if the
branch is not main (a condition on PRs would also work, but we
leave the possibility of running tests on others branches with
this approach). Furthermore, this also adds a condition in the tests
such that only on main the tests are run.
Closes #435