Test.yml: remove allow-failure #48
Conversation
allow-failure: false is the default, Adding it in the matrix, breaks subsequent include: modifications. E.g. see this run on TulipaIO: https://github.com/TulipaEnergy/TulipaIO.jl/actions/runs/7977712404 Instead of overiding allow-failure it creates duplicate runs. This is inline with the docs: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations See the rule for {fruit:banana}
|
I would like to meet the person who created these rules of precedence 😖 |
|
Can't reproduce using https://github.com/nektos/act and the workflow name: Test
on:
push:
jobs:
test:
name: Test
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
version:
- "1.6"
- "1"
allow_failure: [false]
include:
- version: nightly
allow_failure: true
- version: 1
allow_failure: true
steps:
- run: |
echo "Version ${{ matrix.version }}, allow_failure=${{ matrix.allow_failure }}"Running Let me know if I am wrong. That being said, I noticed that I nightly should not have been included in the list. It is duplicated in the template. |
|
Yes, but that's not the correct behaviour. You never want to run the same pipeline twice once with In the above test example, these are the final options:
In the case of the template
when the intention was actually to override 1.
That's a separate issue. Although, removing it from the list does "solve" this one. |
|
Ah, ok, that makes sense. That being said, removing allow_failure is still not the solution, because the example workflow still generates 4 jobs, apparently. 2 of them have empty allow_failure (which I suppose sets a default allow_failure). |
This is strange because the docs say otherwise, see the first two examples with Agree with dropping |
|
Indeed you're right. I've created a playground repo and can reproduce the docs behaviour: https://github.com/abelsiqueira/github-workflow-playground/actions/runs/8037366367. Can we close this? |
|
Sure, we can close |
allow-failure: falseis the default, Adding it in the matrix, breaks subsequent include: modifications. E.g. see this run on TulipaIO. Instead of overidingallow-failure, it creates duplicate runs.This is inline with the docs. See the rule for
{fruit:banana}.