We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From Discord:
nitpicking, you could save a line by binding login directly as a reason-promise: external login: unit => Promise.Js.t(authResponse, Js.Promise.error) = "login" then you can get rid of the ->Promise.Js.fromBsPromise, which is a no-op at run time anyway. looking at that, it might be good to add a helper type abbreviaton to the library, so you can do something like extern login: unit => Promise.Js.raw(authResponse) = "login"
nitpicking, you could save a line by binding login directly as a reason-promise:
login
external login: unit => Promise.Js.t(authResponse, Js.Promise.error) = "login"
then you can get rid of the ->Promise.Js.fromBsPromise, which is a no-op at run time anyway.
->Promise.Js.fromBsPromise
looking at that, it might be good to add a helper type abbreviaton to the library, so you can do something like
extern login: unit => Promise.Js.raw(authResponse) = "login"
The text was updated successfully, but these errors were encountered:
No branches or pull requests
From Discord:
The text was updated successfully, but these errors were encountered: