Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore (or add) Luv/Unix sockaddr conversions #92

Open
aantron opened this issue Jan 14, 2021 · 2 comments
Open

Restore (or add) Luv/Unix sockaddr conversions #92

aantron opened this issue Jan 14, 2021 · 2 comments

Comments

@aantron
Copy link
Owner

aantron commented Jan 14, 2021

...also needed for ocsigen/lwt#813.

@zbaylin
Copy link

zbaylin commented May 2, 2021

Hey @aantron -- is there any way I can help with this? Not sure if you remember but I'm interested in this as well for using luv with ocurl and it looks like the requisite functions (uv_pipe & uv_socketpair) are in now.

Let me know if there is anything I can do!

cc @bryphe

@aantron
Copy link
Owner Author

aantron commented May 2, 2021

I just merged in a branch that restores the Luv/Unix fd conversions in a module Luv.Unix. You should be able to add sockaddr conversions in that module as well, probably in a new submodule module Sockaddr : (* ... *), parallel to Os_fd. It's probably best to do the conversions at the C level, using the functions in caml/socketaddr.h. See luv_unix.c.

I can also add them myself, but a bit later, as I am currently loaded with some other work :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants