Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using href="#*" spams browser history #390

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: using href="#*" spams browser history #390

merged 1 commit into from
Apr 9, 2024

Conversation

karrakoliko
Copy link
Contributor

@karrakoliko karrakoliko commented Apr 8, 2024 •
edited
Loading

I am targeting this branch, because i don't see these files in 2.x.

Closes #389

Changelog

### Added

### Changed
Replaced `<a href="*">` to `<div data-bs-target="*">`

### Deprecated

### Removed

### Fixed

### Security

To do

  • Update the tests
  • Update the documentation
  • Add an upgrade note

Subject

webda2l
webda2l requested changes Apr 9, 2024
View reviewed changes
src/Resources/views/bootstrap_4_layout.html.twig Outdated Show resolved Hide resolved
src/Resources/views/macros.html.twig Outdated Show resolved Hide resolved
src/Resources/views/bootstrap_3_layout.html.twig Outdated Show resolved Hide resolved
src/Resources/views/macros_bootstrap_3.html.twig Outdated Show resolved Hide resolved
src/Resources/views/macros_bootstrap_4.html.twig Outdated Show resolved Hide resolved
@karrakoliko
Copy link
Contributor Author

@webda2l done

@karrakoliko karrakoliko requested a review from webda2l April 9, 2024 13:57
webda2l
webda2l approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@webda2l webda2l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@webda2l webda2l merged commit 7c0a3a1 into a2lix:master Apr 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webda2l webda2l webda2l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using href="#***" in tab spams browser history
2 participants
@karrakoliko @webda2l