Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All My Slide is visible when start #73

Open
sunupf opened this issue Dec 25, 2018 · 4 comments
Open

All My Slide is visible when start #73

sunupf opened this issue Dec 25, 2018 · 4 comments
Labels

Comments

@sunupf
Copy link

sunupf commented Dec 25, 2018

Hi,

I try to separated one component for 1 slide , you can access my code here https://codesandbox.io/s/w0q3jr6mp5

As you can see. Both of Slides showed at the first time we run the slide.

more over, the transition when using LeavePrev and LeaveNext is broken also

Can you help me? because I don't see any error message on console.

Thanks

@yaodingyd
Copy link
Collaborator

It might be bug introduced by 0.4.2. I'll take a look. Thanks!

@yaodingyd yaodingyd added the bug label Dec 26, 2018
@yaodingyd
Copy link
Collaborator

The bug is fixed in 0.4.3.

You also need to set your slideshow(slide1 and slide2) to be inserted to be working https://codesandbox.io/s/10pn34k3mj

All nested slideshow need to set to either inserted or embedded https://github.com/Zulko/eagle.js#nested-slideshow

@yaodingyd
Copy link
Collaborator

The remaining issue is for slide transition effect can't be visible when slideshow is turning to inactive

@sunupf
Copy link
Author

sunupf commented Dec 27, 2018

Noted. Will check it soon. Awesome update (y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants