-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Enable spellcheck by default or provide option to enable it #89
Comments
you need to understand how to integrate it and if it works with all languages. Is anyone an expert in this area? |
AFAIK this just enables the browser spell check feature on the client side. At least that’s what it did for me in Safari on macOS when I manually changed it to true by editing the HTML. I don’t believe it’s a server side feature. In my earlier testing the browser would not detect any spelling errors event when I manually asked it to “Check spelling now” on the page. After I enable spellcheck in the HTML of the page the browser was able to find the spelling errors. I can try to check later in other browsers and in other OSs to confirm. |
I just revisited the doc about it and I think my interpretation is correct.
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck and here ...
https://dev.to/dailydevtips1/html-spellcheck-attribute-4341 Browser support seems very good with the most recently added one (according to the Mozilla doc) being Firefox on Android back in 2017. All other browsers added support for it earlier than that and Chrome was way back in 2011. I'm pretty certain this is just enabling the standard browser spellchecking we see in many other instances in textarea fields, but I can do additional testing later today when I'm back at my main system(s). |
ok I wait for your tests. |
Ok final comment for now. Sorry I'm kind of discovering things in real-time and documenting as I go so I don't lose track of things. It seems this might actually be the codemirror spell checker based on the way it highlights the words (solid red background instead of red underline). https://github.com/sparksuite/codemirror-spell-checker Might partially explain why the HTML tag attribute of I believe there was an assumption on my part earlier on that setting Maybe you're able to do some further testing / investigation to verify? |
Looks like what I have been seeing is a combination of the CodeMirror spell checker (maybe?) and the browser spell checker. If I enable Apologies for not catching this earlier. This means that the issues is maybe more complex than originally thought and that it may or may not work in all languages since I don't know anything about the CodeMirror spell checker in that regard. Maybe it is not as simple (or possible at all?) to enable the client side, native browser spell checking... 🤔 |
Further indication that the spell check feature is not browser side and probably should not be enabled by default... It looks like it does not adhere to the browser localization as it's marking British / Canadian spellings of words as incorrect. I am in Canada and my OS / browser accept Canadian spellings as correct and those show as correct when using the spellcheck HTML attribute Unless there is a way to turn on the actual HTML spellcheck tag I think that at best WikiDocs could provide a cleaner mechanism to turn on the EasyMDE spell checker with the caveat that it's not localized necessarily and it would be up to the Maybe further digging will reveal a way to enable the browser side spellchecker HTML tag... Sorry for the long winded thread @Zavy86, you were right in the beginning and I made assumptions! |
Describe the feature
Spellcheck is disabled by default and there seems to be no 'clean' way to enable it except for mapping the /scripts directory to the host and modifying the setting. That's not ideal since any future changes to those scripts in the project would need to be manually updated / merged.
It would be great to either have spellcheck enabled by default or have an option (either global or in the editor) to enable spellcheck.
Having it enable by default seems logical being that a wiki is typically used for writing notes / documents / articles, etc which are mostly medium to long form text for which spellcheck would be beneficial.
Is your feature request related to a problem? (optional)
I did not notice that spellcheck was disabled and now have a lot of wiki pages with spelling errors I have to go back and manually correct by copy / pasting into a spell check enabled editor and back again.
Screenshots (optional)
Extra fields
The text was updated successfully, but these errors were encountered: