From 95803813cbd9a4bdf51bf18f5b82a1a67a863fc7 Mon Sep 17 00:00:00 2001
From: zaraki596 <rohansingh94117@gmail.com>
Date: Wed, 27 Jan 2021 00:30:07 +0530
Subject: [PATCH] Updated Photos View with StaggeredGridLayout Way

---
 .../splashapp/ui/photos/PhotosActivity.kt     |  4 ++-
 app/src/main/res/layout/row_item_photos.xml   | 35 +++++++------------
 2 files changed, 15 insertions(+), 24 deletions(-)

diff --git a/app/src/main/java/com/example/splashapp/ui/photos/PhotosActivity.kt b/app/src/main/java/com/example/splashapp/ui/photos/PhotosActivity.kt
index 0b34990..1768a66 100644
--- a/app/src/main/java/com/example/splashapp/ui/photos/PhotosActivity.kt
+++ b/app/src/main/java/com/example/splashapp/ui/photos/PhotosActivity.kt
@@ -67,7 +67,8 @@ class PhotosActivity : AppCompatActivity() {
             when (state) {
                 is State.Loading -> binding.progressHorizontal.show()
                 is State.Success -> {
-                    adapter.submitList(state.data.take(6))
+                    //Only taking n photos at a given time
+                    adapter.submitList(state.data.take(10))
                     binding.progressHorizontal.hide()
                 }
                 is State.Error -> {
@@ -81,6 +82,7 @@ class PhotosActivity : AppCompatActivity() {
 
     private fun setUpRecylerView() {
         binding.recyclerPhotos.adapter = adapter
+        binding.recyclerPhotos.setHasFixedSize(true)
     }
 
     private fun setupToolbar() {
diff --git a/app/src/main/res/layout/row_item_photos.xml b/app/src/main/res/layout/row_item_photos.xml
index 010b4b3..f764901 100644
--- a/app/src/main/res/layout/row_item_photos.xml
+++ b/app/src/main/res/layout/row_item_photos.xml
@@ -3,32 +3,21 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/card_row_item"
     android:layout_width="match_parent"
-    android:layout_height="@dimen/dimen_photos_height"
+    android:layout_height="wrap_content"
     android:layout_margin="10dp"
-    app:cardCornerRadius="@dimen/dimen_card_radius"
-    app:cardElevation="@dimen/dimen_card_elevation">
-
-    <androidx.constraintlayout.widget.ConstraintLayout
-        android:layout_width="match_parent"
-        android:layout_height="match_parent">
+    app:cardCornerRadius="@dimen/cardview_default_radius"
+    app:cardElevation="@dimen/cardview_default_elevation">
 
 
-        <ImageView
-            android:id="@+id/image_photos"
-            android:layout_width="match_parent"
-            android:layout_height="match_parent"
-            android:contentDescription="@string/cover_photo_content_desc"
-            android:scaleType="centerCrop"
-            app:layout_constraintBottom_toBottomOf="parent"
-            app:layout_constraintEnd_toEndOf="parent"
-            app:layout_constraintHorizontal_bias="1.0"
-            app:layout_constraintStart_toStartOf="parent"
-            app:layout_constraintTop_toTopOf="parent"
-            app:layout_constraintVertical_bias="0.0"
-            tools:srcCompat="@tools:sample/backgrounds/scenic[10]" />
-
+    <ImageView
+        android:id="@+id/image_photos"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:adjustViewBounds="true"
+        android:contentDescription="@string/cover_photo_content_desc"
+        android:scaleType="fitXY"
+        tools:srcCompat="@tools:sample/backgrounds/scenic[10]" />
 
 
-    </androidx.constraintlayout.widget.ConstraintLayout>
+</com.google.android.material.card.MaterialCardView>
 
-</com.google.android.material.card.MaterialCardView>
\ No newline at end of file