Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you add an argument 'sample_weight_test' in the defination of RandomForestRegressorWithWeights #25

Open
qingnanl opened this issue Oct 25, 2024 · 0 comments

Comments

@qingnanl
Copy link

Hello developers,

Many thanks for your great work iRF; it has great potential in many application scenarios. While I was working on a regression problem, I noticed that when I tried to use RandomForestRegressorWithWeights, an argument (although default None) 'sample_weight_test' was passed to RandomForestRegressorWithWeights, while it was not defined in RandomForestRegressorWithWeights. This caused an error of TypeError: fit() got an unexpected keyword argument 'sample_weight_test'. I think it could be simply resolved by adding an argument 'sample_weight_test' in the defination of RandomForestRegressorWithWeights, as many won't really give any test sample weights at all.

Many thanks,
Qingnan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant