Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google preview snippet does not show workspace changes #512

Open
2 tasks done
Jashi opened this issue Sep 14, 2022 · 3 comments
Open
2 tasks done

Google preview snippet does not show workspace changes #512

Jashi opened this issue Sep 14, 2022 · 3 comments
Labels

Comments

@Jashi
Copy link

Jashi commented Sep 14, 2022

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

If an editor edits the seo title or seo description in a workspace the changes are shown immediately in the google preview snippet but after saving the changes the preview snippet will go back to showing the live content (because yoast renders the page without workspace mode and "reads" title and description).

Please describe what you expected to happen and why.

As an editor I expect the preview snippet to show my current code - in or outside of a workspace. Otherwise I have to publish content to see the result which is not desirable.

How can we reproduce this behavior?

  1. Edit the seo title and/or description in workspace
  2. Save your changes

Technical info

  • TYPO3 version: 9, 10, 11
  • Yoast SEO version: 7.2 and 8.3
@Jashi
Copy link
Author

Jashi commented Oct 18, 2022

Ok, we've used the Hook provided by Yoast to modify the URL for our workspace, so this isn't a problem in our project anymore.

@RinyVT
Copy link
Collaborator

RinyVT commented Oct 18, 2022

Hi @Jashi,

I'm planning to take a look at this for the upcoming major version.
Problem with these workspace changes, and for example #319, is that we first do a request to a backend route, which in turn does the actual page request.
The actual page request does not include the current backend user session so it's important that making this a possibility does not introduce security issues.
Was it only a change in the URL for you to make it work, or did you also have to do some other changes?

@Jashi
Copy link
Author

Jashi commented Oct 19, 2022

Yes, we simply changed the URL. We don't have different backend user rights so that was not an issue fortunately.

@RinyVT RinyVT added the feature label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants