-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an own Python package for the REST interface #461
Comments
Forked MOE and striped some code so now have the REST client with only minimal dependencies and no C++ code Only dependancies are:
https://github.com/mulyoved/clientMOE It is only quick and totally dirty hack for now |
@mulyoved Yes, great! Looking forward to use it. Will you upload a package to PyPI? |
published as PyPI package
|
@mulyoved Nice, just installed it with pip! Thanks a bunch! |
My understanding is that clientMOE requires python 2.7. What are the barriers to making it python 3 compatible? |
I have forked this and done a quick-and-dirty conversion to python3 (3.5.2). https://github.com/RokoMijic/clientMOE Due to @mulyoved 's code not including the CPP wrappers, a number of tests simply had to be deleted since they relied on that code. There are 91 remaining tests which all pass in python 3.5.2. |
Currently the installation of MOE is quite hard for beginners. Although a docker image is provided which makes is easy to get it running, in order to use the provided Python REST interface one still has to install MOE somehow locally or start messing around with the PYTHONPATH variable which is just nasty.
My suggestion would be to split the whole Python REST interface into an own library called
moe_api
for instance. The installation for dummies would then be as easy as running the provided docker image and typingpip install moe_api
in a virtuelenv or conda environment. Sincemoe_api
would be plain Python code there is nothing to compile and even a port of that client to Python 3 would be so much easier. During this cleanup one could surely simplify the current interface.The text was updated successfully, but these errors were encountered: