Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue warnings in multistart_hyperparameter_optimization of python version #441

Open
yf275 opened this issue Aug 24, 2015 · 1 comment
Open

Comments

@yf275
Copy link

yf275 commented Aug 24, 2015

Hi,

For the one in optimal_learning/python/python_version/log_likelihood.py, Line 107 is trying to apply numpy.log10 on hyperparameter_optimizer.domain._domain_bounds. I think we should issue a warning to users when they include negative values in domain_bounds so numpy.log10 would return a number instead of nan Similar thing for Line 128 of log_likelihood.py in optimal_learning/python/cpp_wrappers/log_likelihood.py.

@yf275 yf275 changed the title [Bugs] multistart_hyperparameter_optimization in python Issue warnings in multistart_hyperparameter_optimization of python version Aug 24, 2015
@suntzu86
Copy link
Contributor

suntzu86 commented Nov 4, 2015

Sorry I've been gone for so long! See: #448 for details.

This is similar to #446, I think. Sorry, yes MOE's input validity checking isn't very thorough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants