Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component clone tool should work on inspectors #3154

Open
art0007i opened this issue Nov 1, 2024 · 9 comments
Open

Component clone tool should work on inspectors #3154

art0007i opened this issue Nov 1, 2024 · 9 comments
Labels
already exists The requested functionality already exists in some form needs more information More information is requested about this issue. New Feature A new addition, whose complexity hasn't been evaluated yet

Comments

@art0007i
Copy link

art0007i commented Nov 1, 2024

Is your feature request related to a problem? Please describe.

Currently the component clone tool can clone a component from an inspector, but it cannot paste the component onto another inspector to apply the cloned components to the inspected object. Instead it will apply those components to the actual inspector itself.
I find it that most of the time objects I'd want to clone components onto do not have colliders, which means I can't use the component clone tool on it.
I am aware of the feature of "dragging" components between inspector, which can be nice, but the component clone tool does not require you to hold the component you want to clone all the time in your hand, and you can have multiple component clone tools to clone different components quickly. I think this tool could be very powerful and useful if it had this functionality.

Describe the solution you'd like

clicking with the tool on an inspector would clone components onto the inspected object, instead of the panel itself.

Describe alternatives you've considered

the drag drop functionality, but it has some limitations which the component clone does not have.

Additional Context

this used to be the case on oldplatform but not sure why it was removed. best guess is that the new inspector doesn't allow you to click on it because it's a canvas which captures your clicks instead of letting the tool click the inspector, but I think that there is a better solution than removing the useful functionality.

Requesters

No response

@art0007i art0007i added the New Feature A new addition, whose complexity hasn't been evaluated yet label Nov 1, 2024
@shiftyscales shiftyscales removed their assignment Nov 1, 2024
@shiftyscales shiftyscales added the already exists The requested functionality already exists in some form label Nov 1, 2024
@shiftyscales
Copy link
Collaborator

@art0007i - To use the component clone tool with the inspector- grab the slot you want to attach the cloned component to and press secondary. Does that not meet your needs in some way?

@shiftyscales shiftyscales added the needs more information More information is requested about this issue. label Nov 1, 2024
@3x1t-5tyl3
Copy link

3x1t-5tyl3 commented Nov 2, 2024

@art0007i - To use the component clone tool with the inspector- grab the slot you want to attach the cloned component to and press secondary. Does that not meet your needs in some way?

You used to be abel to grab the slot ref and hit secondary to make a template..

That's kinda impossible now as it is overriden by the paste command?
How are we supposed to clone with it so I can paste with it?
Also seperately: #3145
edit: Corrections

@art0007i
Copy link
Author

art0007i commented Nov 2, 2024

@shiftyscales I see, I was not aware that pasting via slot reference even exists, I guess this doesn't meet my needs in the form that I've used a ToolSimulator to attach components to specific objects on the old platform, which is now not possible because the ToolSimulator cannot hold a reference to a slot. Though my use case might be going above the tools intended purpose at that point.

I still think that this behavior is slightly intuitive because both the copy and paste actions are on secondary, but change depending on what reference you are holding (slot or component)

@3x1t-5tyl3
Copy link

@shiftyscales I see, I was not aware that pasting via slot reference even exists, I guess this doesn't meet my needs in the form that I've used a ToolSimulator to attach components to specific objects on the old platform, which is now not possible because the ToolSimulator cannot hold a reference to a slot. Though my use case might be going above the tools intended purpose at that point.

I still think that this behavior is slightly intuitive because both the copy and paste actions are on secondary, but change depending on what reference you are holding (slot or component)

Doesn't this mean that while the component clone supports multiple components, it is never able to do so alone? lol

@shiftyscales
Copy link
Collaborator

Curious for input from @ProbablePrime or @Frooxius.

Doesn't this mean that while the component clone supports multiple components

I wasn't aware the component clone tip could ever officially support / clone multiple components / an entire slot as a template- are you certain that functionality existed prior? The only time I had ever done anything similar was by manually inspecting the tool with a DevTool and adding additional components to the template slot myself- which goes beyond the scope of its intended use.

I've used a ToolSimulator to attach components to specific objects on the old platform, which is now not possible because the ToolSimulator cannot hold a reference to a slot. Though my use case might be going above the tools intended purpose at that point.

Yeah- that's probably also a bit beyond the intended bounds of the tool's design- that would probably be best resolved by #57. Do you have content that was broken by that change that you're only just now noticing? Or was it just a temporary workflow solution you employed that isn't in any finalized projects?

@3x1t-5tyl3
Copy link

3x1t-5tyl3 commented Nov 2, 2024

Curious for input from @ProbablePrime or @Frooxius.

Doesn't this mean that while the component clone supports multiple components

I wasn't aware the component clone tip could ever officially support / clone multiple components / an entire slot as a template- are you certain that functionality existed prior? The only time I had ever done anything similar was by manually inspecting the tool with a DevTool and adding additional components to the template slot myself- which goes beyond the scope of its intended use.

I've used a ToolSimulator to attach components to specific objects on the old platform, which is now not possible because the ToolSimulator cannot hold a reference to a slot. Though my use case might be going above the tools intended purpose at that point.

Yeah- that's probably also a bit beyond the intended bounds of the tool's design- that would probably be best resolved by #57. Do you have content that was broken by that change that you're only just now noticing? Or was it just a temporary workflow solution you employed that isn't in any finalized projects?

Edit: Yeah nevermind the adding part is not multi-component. But it did support it really well when added manually to a template slot.

@Frooxius
Copy link
Member

Frooxius commented Nov 2, 2024

Yes, the tool has supported multiple components since its initial design.

@shiftyscales
Copy link
Collaborator

I guess that functionality was overlooked when updating how they function with inspectors then, @Frooxius? Any suggestions for how to best resolve this issue, then?

@art0007i
Copy link
Author

art0007i commented Nov 2, 2024

Do you have content that was broken by that change that you're only just now noticing?

Yes. I have a pretty simple tool that attaches a dynamic variable space called "Data" onto the world root slot. I use this tool so I don't have to lag my game by opening the root slot in an inspector panel, and the "Data" space can be useful for specific music reactivity system which require it to be present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
already exists The requested functionality already exists in some form needs more information More information is requested about this issue. New Feature A new addition, whose complexity hasn't been evaluated yet
Projects
None yet
Development

No branches or pull requests

4 participants