Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command unsupported in 2015 netcode #51

Open
Skipper-is opened this issue Jul 21, 2023 · 2 comments
Open

Command unsupported in 2015 netcode #51

Skipper-is opened this issue Jul 21, 2023 · 2 comments
Assignees
Labels
bug Something isn't working fix provided Reporter has included a potential solution to the bug. netcode Bug/Feature relates to netcode.

Comments

@Skipper-is
Copy link

For backwards compatibility - 2015 versions of YSFLIGHT are not forwards compatible due to this function in the netcode:
https://github.com/YSCEDC/YSCE/blob/616283861fac7a07fde7d60dfa48e7fe8d21d16a/src/core/fsnetwork.cpp#L4343C1-L4355C2

When bypassed, they are able to log on fine. Need to add version check if we're going to enable forwards compatibility for vanilla YSFLIGHT.

@Skipper-is Skipper-is added bug Something isn't working netcode Bug/Feature relates to netcode. labels Jul 21, 2023
@NodokaHanamura NodokaHanamura added the fix provided Reporter has included a potential solution to the bug. label Jul 21, 2023
@NodokaHanamura
Copy link
Member

Any status on this, Skipper?

@Skipper-is
Copy link
Author

Partially, so I've got a version check that will fire off if the client is using YSCE, allowing the server to have a record of who is a YSCE client, and who is a vanilla client, thus allowing YSCE commands to be sent only to YSCE clients, but I'm putting it on the back burner until I get the weather sorted, as that'll have a lot of YSCE only net code to go with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix provided Reporter has included a potential solution to the bug. netcode Bug/Feature relates to netcode.
Projects
None yet
Development

No branches or pull requests

2 participants