Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing VE tests #505

Open
wgip opened this issue Feb 20, 2022 · 0 comments
Open

Failing VE tests #505

wgip opened this issue Feb 20, 2022 · 0 comments

Comments

@wgip
Copy link
Contributor

wgip commented Feb 20, 2022

As part of #501, we bring back Dynamic VE tests, however, some of them are failing (so ignored for now).
This Issue is to track the work to fix these failing test cases.

VectorEngine / testOnly *Dynamic* -- -z "Support pairwise addition with shorts"
VectorEngine / testOnly *Dynamic* -- -z "Support filtering"
VectorEngine / testOnly *Dynamic* -- -z "Boolean query does not crash"
VectorEngine / testOnly *Dynamic* -- -z "Timestamps are supported"
wgip added a commit that referenced this issue Feb 20, 2022
wgip added a commit that referenced this issue Feb 20, 2022
- Brought back `DynamicVeSqlExpressionEvaluationSpec` to reproduce the Parquest error case. Found several other test failures, documented them in #505.
- Created `ColumnarBatchToVeColBatch` & updated `SparkToVectorEnginePlan` to use it. The default mode uses `InternalRow`s as the transformation mechanism, whereas col-to-col implementation is to be implemented separately, as an optimization.
- For the col-to-col implementation we add a unit test case to validate it, as part of the optimization implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant