Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

build: add maven-shade for netty #67

Open
wants to merge 3 commits into
base: thrift-0.11.0-inlined
Choose a base branch
from

Conversation

foreverneverer
Copy link
Contributor

No description provided.

@foreverneverer foreverneverer changed the title add maven-shade build: add maven-shade Nov 13, 2019
pom.xml Outdated Show resolved Hide resolved
@neverchanje neverchanje changed the title build: add maven-shade build: add maven-shade for netty Nov 13, 2019
@foreverneverer foreverneverer changed the title build: add maven-shade for netty build: add maven-shade Nov 14, 2019
@neverchanje
Copy link

这次改动较大。

如果要 shade netty,那么下一个版本应该是 2.0.0,因为改 netty 因为涉及到接口改动,是不向下兼容的。所以你这次改动应该分成两个 PR 拆,一步是改 guava, thrift, etc,一步是改 netty。我们要维护两个版本分支,也就是两个 git branch,一个 是 v2.0(与 pegasus 版本命名一致),一个是 1.11-thrift-0.11.0-inlined-release。不愿意改动代码的用户我们也要支持。

@neverchanje
Copy link

另外 thrift 这个 shade 的改动也很大了,容易出错,建议 thrift 单独一个 PR

@foreverneverer
Copy link
Contributor Author

另外 thrift 这个 shade 的改动也很大了,容易出错,建议 thrift 单独一个 PR

是的,的确改动很大,单独提吧。

@foreverneverer
Copy link
Contributor Author

这次改动较大。

如果要 shade netty,那么下一个版本应该是 2.0.0,因为改 netty 因为涉及到接口改动,是不向下兼容的。所以你这次改动应该分成两个 PR 拆,一步是改 guava, thrift, etc,一步是改 netty。我们要维护两个版本分支,也就是两个 git branch,一个 是 v2.0(与 pegasus 版本命名一致),一个是 1.11-thrift-0.11.0-inlined-release。不愿意改动代码的用户我们也要支持。

恩,应该这样!

@foreverneverer foreverneverer changed the title build: add maven-shade build: add maven-shade for netty Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants